Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function application signature help - improvements list #10957

Closed
2 tasks done
cartermp opened this issue Jan 27, 2021 · 2 comments
Closed
2 tasks done

Function application signature help - improvements list #10957

cartermp opened this issue Jan 27, 2021 · 2 comments

Comments

@cartermp
Copy link
Contributor

cartermp commented Jan 27, 2021

This tracks improvements to the signature help feature for function applications.

  • Tooltip disappears when typing out arguments in a function application

This one is tricky with the current implementation. We can either:

  • Keep the tooltip up when typing out arguments to a function application
  • Keep the tooltip up when typing out arguments in a method call

The latter has always worked, so it's currently implemented to do that. But it'll be more work to figure out how to do both.

  • Still triggers unexpectedly inside of a parenthesized context

As of #10954 this should be improved a lot, since it covers parenthesized contexts that have a lambda. But it can still trigger in cases like this:

image

To address this, we'll need to figure out a way to generalize the parenthesized case for TryRangeOfFunctionOrMethodBeingApplied.

@cartermp
Copy link
Contributor Author

For the general parenthesized case, it may be enough to get away with just two more matches; one on SynExpr.Parent(SynExpr.Paren(... and another on SynExpr.Paren(SynExpr.Tuple(.... I'll see if that feel sufficient or not.

@cartermp
Copy link
Contributor Author

cartermp commented Feb 6, 2021

closing out for now

@cartermp cartermp closed this as completed Feb 6, 2021
@cartermp cartermp modified the milestones: Backlog, 16.10 Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant