Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong "rec" code fix suggestion for static members #11194

Closed
Tracked by #15408
SchlenkR opened this issue Mar 7, 2021 · 0 comments · Fixed by #11199
Closed
Tracked by #15408

Wrong "rec" code fix suggestion for static members #11194

SchlenkR opened this issue Mar 7, 2021 · 0 comments · Fixed by #11199
Assignees
@cartermp
Labels
Area-LangService-API Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
16.10

Comments

@SchlenkR
Copy link
Contributor

SchlenkR commented Mar 7, 2021

See the attached screenshot:

image

The "Make recursive" suggestion provided in the context of static methods leads to wrong code.

I suggest to either

  • remove that code fix in this context or
  • introduce a code fix that inserts the type to be able to make the recursive call to the static method.
@cartermp cartermp added this to the 16.10 milestone Mar 7, 2021
@cartermp cartermp self-assigned this Mar 7, 2021
@cartermp cartermp added the Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. label Mar 7, 2021
@cartermp cartermp mentioned this issue Mar 9, 2021
Merged
@psfinaki psfinaki added the Area-LangService-CodeFixes Code fixes associated with diagnostics label Jun 15, 2023
@psfinaki psfinaki mentioned this issue Jun 15, 2023
Open
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cartermp cartermp

Labels
Area-LangService-API Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
None yet
Milestone
16.10
Development

Successfully merging a pull request may close this issue.

Don't trigger 'make binding recursive' in members cartermp/fsharp
3 participants
@SchlenkR @psfinaki @cartermp