Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange backticks in auto-complete #13061

Closed
dsyme opened this issue Apr 28, 2022 · 8 comments · Fixed by #13552
Closed

Strange backticks in auto-complete #13061

dsyme opened this issue Apr 28, 2022 · 8 comments · Fixed by #13552
Assignees
Labels
Area-LangService-AutoComplete autocomplete/intellisense Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Regression
Milestone

Comments

@dsyme
Copy link
Contributor

dsyme commented Apr 28, 2022

The following shows strange backticks, after pressing space where the cursor is:

image

@dsyme dsyme added Bug Regression Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Area-LangService-AutoComplete autocomplete/intellisense labels Apr 28, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Jun 17, 2022
@dsyme
Copy link
Contributor Author

dsyme commented Jun 21, 2022

This might be a good first issue, it might be because an empty string for "no parameter name" is getting backticks, and the parameter name is not being skipped

@vzarytovskii
Copy link
Member

I know that @psfinaki is working on tooltips for keywords issue, might be interested in this one too?

@psfinaki
Copy link
Member

Yeah I can jump on that shortly.

@psfinaki psfinaki self-assigned this Jun 23, 2022
@vzarytovskii vzarytovskii moved this from Not Planned to Planned in F# Compiler and Tooling Jun 23, 2022
@psfinaki
Copy link
Member

@dsyme can reproduce and have an idea for a fix. Just what do we actually want there? Generated arguments names like arg1, arg2 and so on?

@kerams
Copy link
Contributor

kerams commented Jun 24, 2022

Generated arguments names like arg1, arg2 and so on?

Surely they are known/defined but not propagated correctly in some contexts?

@dsyme
Copy link
Contributor Author

dsyme commented Jun 29, 2022

@psfinaki let's chat via teams later today

@vzarytovskii
Copy link
Member

Generated arguments names like arg1, arg2 and so on?

Surely they are known/defined but not propagated correctly in some contexts?

They are, except some places like

let inline apply callback a = callback a

Then, when we try to get hints for callback, it doesn't have an argument name.

@psfinaki psfinaki added this to the July-2022 milestone Jul 11, 2022
@psfinaki
Copy link
Member

Minimal repro is let f g x = g x

@psfinaki psfinaki linked a pull request Jul 22, 2022 that will close this issue
Repository owner moved this from Planned to Done in F# Compiler and Tooling Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-AutoComplete autocomplete/intellisense Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Regression
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants