Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2022 Colouring is broken when resetting "Fonts and Colors" to default values #13927

Open
vzarytovskii opened this issue Sep 19, 2022 · 4 comments
Labels
Area-VS-Editor VS editor support for F# code, not covered elsewhere Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Regression
Milestone

Comments

@vzarytovskii
Copy link
Member

vzarytovskii commented Sep 19, 2022

DISCLAIMER: Please, don't try reproducing it on your VS 17.4+ instance, since you will likely have a broken colouring till the fix is released.

When resetting fonts and colors to default values (Tools -> Options -> Environment -> Fonts and Colors), reloading VS and deleting .vs, VS treats everything as plain text (except keywords):
image

@vzarytovskii vzarytovskii added the Area-VS-Editor VS editor support for F# code, not covered elsewhere label Sep 19, 2022
@vzarytovskii vzarytovskii self-assigned this Sep 19, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Sep 19, 2022
@vzarytovskii vzarytovskii added this to the September-2022 milestone Sep 19, 2022
@vzarytovskii
Copy link
Member Author

It does not reproduce in 17.3

@0101
Copy link
Contributor

0101 commented Sep 21, 2022

Caused by new preview feature in VS: dotnet/roslyn#64168

Fix at the moment is disabling C#/VB LSP semantic tokens experience under Environment -> Preview Features.

@vzarytovskii vzarytovskii removed their assignment Feb 6, 2023
@vzarytovskii vzarytovskii modified the milestones: February-2023, March-2023 Mar 3, 2023
@vzarytovskii vzarytovskii modified the milestones: March-2023, April-20203 Apr 3, 2023
@vzarytovskii vzarytovskii removed this from the April-2023 milestone May 4, 2023
@psfinaki psfinaki self-assigned this Sep 3, 2024
@psfinaki psfinaki added this to the September-2024 milestone Sep 3, 2024
@psfinaki psfinaki moved this from Planned to In Progress in F# Compiler and Tooling Sep 9, 2024
@psfinaki
Copy link
Member

psfinaki commented Sep 9, 2024

@vzarytovskii so this still repros with the above preview feature on.

The matching roslyn issue is here. In the light of LSP 👀 , I'd say it would be enough if this VS setting just doesn't have an effect on F# (as opposed to trying to somehow propagate the logic thru the Roslyn interfaces) - do you agree?

@vzarytovskii vzarytovskii moved this from In Progress to Blocked in F# Compiler and Tooling Sep 18, 2024
@psfinaki
Copy link
Member

psfinaki commented Sep 19, 2024

We talked with @dibarbet about this one:

  • LSP is not going to be enabled in the near future
  • Roslyn doesn't plan to implement F# support for this really
  • It also shouldn't effect the F# colorization based on the implementation
  • The whole thing doesn't reproduce for David

On the other hand, I get disappearing colorization quite often, but only when working with our repo - and also it then randomly appears again, so my case might be unrelated.

Based on this and low activity here for the 2 years, I'll deprio this to Medium for now.

@psfinaki psfinaki added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Sep 19, 2024
@psfinaki psfinaki modified the milestones: September-2024, Backlog Sep 20, 2024
@psfinaki psfinaki removed their assignment Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VS-Editor VS editor support for F# code, not covered elsewhere Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Regression
Projects
Status: Blocked
Development

No branches or pull requests

3 participants