Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Scripts are being edited as .NET Framework, not .NET Core #13993

Closed
dsyme opened this issue Sep 27, 2022 · 3 comments · Fixed by #13994
Closed

Regression: Scripts are being edited as .NET Framework, not .NET Core #13993

dsyme opened this issue Sep 27, 2022 · 3 comments · Fixed by #13994
Assignees
@KevinRansom
Labels
Area-VS-FSI VS window and commands for F# Interactive Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Needs-Triage Regression
Milestone
Backlog

Comments

@dsyme
Copy link
Contributor

dsyme commented Sep 27, 2022 •
edited
Loading

In latest public preview and latest main, when opening and editing a script .NET Framework references are being used, not .NET Core references

Script:

#r "nuget: FSharp.Data, 3.3.3"

With 17.3.3:

image

With 17.4.0 Preview 2.1 and latest main:

image

Settings:

image
@dsyme
Copy link
Contributor Author

dsyme commented Sep 27, 2022 •
edited
Loading

Separately, in the options the inclusion of "Use .NET Core Scripting" under "FSI Preview" is wrong - it is now the default so is unrelated to being preview

@dsyme dsyme added the Area-VS-FSI VS window and commands for F# Interactive label Sep 27, 2022
@dsyme dsyme mentioned this issue Sep 27, 2022
Merged
@dsyme
Copy link
Contributor Author

dsyme commented Sep 27, 2022 •
edited
Loading

@KevinRansom Regression is here: dc269a9#r85153150

Fix is below

@dsyme dsyme mentioned this issue Sep 27, 2022
Merged
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Oct 17, 2022
@vzarytovskii vzarytovskii added this to the Backlog milestone Oct 17, 2022
@T-Gro T-Gro added the Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. label Nov 14, 2022
@T-Gro
Copy link
Member

T-Gro commented Nov 14, 2022

(likely have been fixed? @KevinRansom )

@T-Gro T-Gro closed this as completed Nov 14, 2022
Repository owner moved this from Not Planned to Done in F# Compiler and Tooling Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinRansom KevinRansom

Labels
Area-VS-FSI VS window and commands for F# Interactive Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Needs-Triage Regression
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix regression in editing .NET Core scripts in devenv.exe dsyme/fsharp
4 participants
@vzarytovskii @KevinRansom @dsyme @T-Gro