FindReferencesInFile misses references to type when a module with the same name exists

[0101]

Repro steps

Code sample 1

module Foo

type MyType =
    static member Two = 1

let x = MyType.Two

let y = MyType.Two

Code sample 2

module Foo

type MyType =
    static member Two = 1

let x = MyType.Two

module MyType = do () // <-- Extra module with the same name as the type

let y = MyType.Two

1. Find All References on type MyType

Expected behavior

In both code samples we get the same results - 2 references to MyType type.

Actual behavior

In code sample 2 the second reference (y) is missing.

Known workarounds

None

Related information

The second occurrence is incorrectly stored in ItemKeyStore as Item.ModuleOrNamespaces instead of Item.Types. This happens probably because in name resolution we find the identifier in modules, which are searched first.

fsharp/src/Compiler/Checking/NameResolution.fs

Line 3085 in 8e3b97b

moduleSearch ad () +++ tyconSearch ad +++ envSearch