Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiagnosticSource breaks vs #14413

Closed
vzarytovskii opened this issue Nov 30, 2022 · 1 comment
Closed

DiagnosticSource breaks vs #14413

vzarytovskii opened this issue Nov 30, 2022 · 1 comment
Labels
Area-VS VS support for F# not covered elsewhere Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression
Milestone
Backlog

Comments

@vzarytovskii
Copy link
Member

vzarytovskii commented Nov 30, 2022 •
edited
Loading

PR which introduced diagnosticsource needs to be reverted, as it breaks VS and makes it unusable.

Affected Branch: Main
Affected Build: Version17.5 preview 2 [33129.450.main]
Affected Product Language:
Below workloads are installed.

.NET desktop development
ASP.NET and web development
Universal Windows Platform development
Visual Studio extension development

Steps to reproduce:
1.install VS17.5 preview 2 [33129.450.main]
2.Launch VS and create a F# console project(.net7.0)

Expected result:
The F# console project can be created and running successful without errors.

Actual Result:
Error FS0193 occurred when running F# project
FSC : error FS0193: Could not load file or assembly 'System.Diagnostics.DiagnosticSource, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.
@github-actions github-actions bot added this to the Backlog milestone Nov 30, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Nov 30, 2022
@vzarytovskii vzarytovskii added Area-VS VS support for F# not covered elsewhere Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression and removed Needs-Triage labels Nov 30, 2022
@vzarytovskii vzarytovskii mentioned this issue Nov 30, 2022
Merged
5 tasks
@KevinRansom KevinRansom mentioned this issue Dec 1, 2022
Merged
@T-Gro
Copy link
Member

T-Gro commented Dec 1, 2022

Resolved by #14417

@T-Gro T-Gro closed this as completed Dec 1, 2022
Repository owner moved this from Not Planned to Done in F# Compiler and Tooling Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-VS VS support for F# not covered elsewhere Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@vzarytovskii @T-Gro