Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IDE0049 in F# #14541

Open
Tracked by #15408
psfinaki opened this issue Jan 5, 2023 · 4 comments
Open
Tracked by #15408

Support IDE0049 in F# #14541

psfinaki opened this issue Jan 5, 2023 · 4 comments
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Feature Request
Milestone

Comments

@psfinaki
Copy link
Member

psfinaki commented Jan 5, 2023

This ticket stems from this PR. We should have something to force the guidelines we have for the F# code.

I don't think it should be a Fantomas job, it's basically equivalent to the IDE0049. And since IDE0049 is branded as an "IDE" one (supports both C# and VB), we should likely just implement it in F#.

@github-actions github-actions bot added this to the Backlog milestone Jan 5, 2023
@0101 0101 added Area-LangService-CodeFixes Code fixes associated with diagnostics and removed Needs-Triage labels Apr 3, 2023
@0101
Copy link
Contributor

0101 commented Apr 3, 2023

This should probably be handled by a diagnostic + code fix in VS.

@psfinaki psfinaki mentioned this issue Jun 15, 2023
85 tasks
@Happypig375
Copy link
Member

This may create an inconsistency where to access int.MaxValue like in C#, we must still write

System.Int32.MaxValue

while other uses will be nudged to be converted to int.
Ideally int.MaxValue should just work in F# but it has been declined before. fsharp/fslang-suggestions#740

@psfinaki
Copy link
Member Author

Good point. But we can probably still do it for other primitives.

@Xyncgas

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Feature Request
Projects
Status: New
Development

No branches or pull requests

4 participants