Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify code fix code #15059

Closed
Tracked by #15408
psfinaki opened this issue Apr 11, 2023 · 1 comment · Fixed by #16051
Closed
Tracked by #15408

Unify code fix code #15059

psfinaki opened this issue Apr 11, 2023 · 1 comment · Fixed by #16051
Assignees
@psfinaki
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Area-VS-Editor VS editor support for F# code, not covered elsewhere
Milestone
October-2023

Comments

@psfinaki
Copy link
Member

Some code fixes now go through CodeFixHelpers, others don't. This is important from the point of cross-cutting concerns (e.g. telemetry) as well as contributor-friendliness.

This can be started after some take on: #15043
@psfinaki psfinaki self-assigned this Apr 11, 2023
@psfinaki psfinaki added this to the April-2023 milestone Apr 11, 2023
@github-actions github-actions bot modified the milestones: April-2023, Backlog Apr 11, 2023
@psfinaki psfinaki mentioned this issue Apr 11, 2023
Closed
@psfinaki psfinaki added the Area-VS-Editor VS editor support for F# code, not covered elsewhere label Apr 11, 2023
@0101 0101 removed the Needs-Triage label Apr 17, 2023
@T-Gro
Copy link
Member

T-Gro commented Apr 18, 2023 •
edited
Loading

The following are still needed to be unified.
The API usage is in each of them somewhat special, therefore cannot be just rewritten - has to be more careful ported and functionality retested.

  • FSharpImplementInterfaceCodeFixProvider
  • MissingReferenceCodeFixProvider (changes solution, not document)
  • FSharpProposeUpperCaseLabelCodeFixProvider (uses solutionChanger and changeAllSymbolReferences)
  • DONE FSharpWrapExpressionInParenthesesFixProvider

@psfinaki psfinaki moved this from Not Planned to Planned in F# Compiler and Tooling Jun 5, 2023
@psfinaki psfinaki modified the milestones: Backlog, June-2023 Jun 5, 2023
@psfinaki psfinaki added the Area-LangService-CodeFixes Code fixes associated with diagnostics label Jun 15, 2023
This was referenced Jun 15, 2023
Open
Merged
@psfinaki psfinaki modified the milestones: June-2023, July-2023 Jul 5, 2023
@psfinaki psfinaki removed this from the July-2023 milestone Jul 31, 2023
@psfinaki psfinaki mentioned this issue Sep 26, 2023
Merged
@psfinaki psfinaki added this to the September-2023 milestone Sep 27, 2023
@github-project-automation github-project-automation bot moved this from Planned to Done in F# Compiler and Tooling Oct 2, 2023
@psfinaki psfinaki modified the milestones: September-2023, October-2023 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Area-VS-Editor VS editor support for F# code, not covered elsewhere
Projects
F# Compiler and Tooling
Archived in project
Milestone
October-2023
Development

Successfully merging a pull request may close this issue.

README about working with code fixes psfinaki/fsharp
3 participants
@0101 @psfinaki @T-Gro