Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddOpen code fix might add too many empty lines #15552

Closed
Tracked by #15408
psfinaki opened this issue Jul 4, 2023 · 0 comments · Fixed by #15912
Closed
Tracked by #15408

AddOpen code fix might add too many empty lines #15552

psfinaki opened this issue Jul 4, 2023 · 0 comments · Fixed by #15912
Assignees
@psfinaki
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone
August-2023

Comments

@psfinaki
Copy link
Member

psfinaki commented Jul 4, 2023

Take a look:

bug.mp4

In the first case, the fix adds an extra line and then the open above it - which is reasonable.
In the second case, the fix adds two extra lines and then the open above it - which is okay but why.

This probably isn't a "bug" really, since the code compiles, but not an improvement either, since addressing this wouldn't bring new functionality. Just a small flaw kind of.
@psfinaki psfinaki added the Area-LangService-CodeFixes Code fixes associated with diagnostics label Jul 4, 2023
@github-actions github-actions bot added this to the Backlog milestone Jul 4, 2023
@psfinaki psfinaki mentioned this issue Jul 4, 2023
Open
85 tasks
@0101 0101 added Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Needs-Triage labels Jul 10, 2023
@psfinaki psfinaki mentioned this issue Sep 1, 2023
Merged
@github-project-automation github-project-automation bot moved this from Not Planned to Done in F# Compiler and Tooling Sep 5, 2023
@psfinaki psfinaki modified the milestones: Backlog, August-2023 Sep 7, 2023
@psfinaki psfinaki self-assigned this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
August-2023
Development

Successfully merging a pull request may close this issue.

Improving AddOpen code fix provider psfinaki/fsharp
2 participants
@0101 @psfinaki