A code refactoring to deinterpol a string

[psfinaki]

Suggested by @T-Gro

Basically it could fix the following cases:

let x = $"test"

let y = $"{x}"

Interpolation is useless here - it decreases readability and in the second case has small perf penalty. Change the code to:

let x = "test"

let y = x

Note, $"test" compiles to the "test" so it might be not worth running a code ref in the background for this case.

[abonie]

There are some caveats though. Noob question - can we use type information to decide whether to suggest a code refactoring or not?

Like for let x = $"test" -> let x = "test", we should avoid suggesting it if the initial line is declaring a FormattableString, like let x : System.FormattableString = $"test".
And for the second one, we have to make sure x is a string, we don't want to suggest let y = $"{42}" -> let y = 42.

[kerams]

An interpolated string with no holes compiles to a string. I'd personally not waste CPU cycles in the IDE on this.

[psfinaki]

@abonie, yep, thanks for the notes and examples, that's good to keep in mind.

An interpolated string with no holes compiles to a string. I'd personally not waste CPU cycles in the IDE on this.

@kerams Hmm, good point. Yep, this part is probably not worth it.