Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement **part of** approved suggestion: 'Merge fields of the same type **and name** on multi-case union structs' #15715

Closed
T-Gro opened this issue Jul 31, 2023 · 0 comments · Fixed by #15738
Closed

Implement **part of** approved suggestion: 'Merge fields of the same type **and name** on multi-case union structs' #15715

T-Gro opened this issue Jul 31, 2023 · 0 comments · Fixed by #15738
Assignees
@T-Gro
Labels
Area-Compiler-CodeGen IlxGen, ilwrite and things at the backend Feature Request
Milestone
August-2023

Comments

@T-Gro
Copy link
Member

T-Gro commented Jul 31, 2023

This is a tracking issue for planning purposes, to implement part of fsharp/fslang-suggestions#699 (comment) .

The full suggestion sets higher goals, therefore staling implementation and having several added concerns about limited support (generics,..), loss of debugging quality (field names) and other difficulties (e.g. sizeof being a runtime thing, not compile time).

Targeting fields with equal types and names would:

  • have 0 binary backwards compatibility issues, since those are not allowed as of now
  • maintain same debugging experience
  • lot less riskier to get in
@T-Gro T-Gro self-assigned this Jul 31, 2023
@T-Gro T-Gro added this to the August-2023 milestone Jul 31, 2023
@github-actions github-actions bot modified the milestones: August-2023, Backlog Jul 31, 2023
@T-Gro T-Gro added Area-Compiler-CodeGen IlxGen, ilwrite and things at the backend and removed Needs-Triage labels Jul 31, 2023
@T-Gro T-Gro modified the milestones: Backlog, August-2023 Jul 31, 2023
@T-Gro T-Gro moved this from Not Planned to Planned in F# Compiler and Tooling Jul 31, 2023
@T-Gro T-Gro mentioned this issue Aug 2, 2023
Merged
@T-Gro T-Gro linked a pull request Aug 2, 2023 that will close this issue
Field sharing for [<Struct>] DUs if they have equal name and equal type #15738
Merged
@github-project-automation github-project-automation bot moved this from Planned to Done in F# Compiler and Tooling Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T-Gro T-Gro

Labels
Area-Compiler-CodeGen IlxGen, ilwrite and things at the backend Feature Request
Projects
F# Compiler and Tooling
Archived in project
Milestone
August-2023
Development

Successfully merging a pull request may close this issue.

Field sharing for [<Struct>] DUs if they have equal name and equal type T-Gro/fsharp
1 participant
@T-Gro