Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplaceWithSuggestion code fix suggests at max 1 thing #15890

Closed
Tracked by #15408
psfinaki opened this issue Aug 28, 2023 · 0 comments · Fixed by #16004
Closed
Tracked by #15408

ReplaceWithSuggestion code fix suggests at max 1 thing #15890

psfinaki opened this issue Aug 28, 2023 · 0 comments · Fixed by #16004
Assignees
@psfinaki
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone
September-2023

Comments

@psfinaki
Copy link
Member

Compare the code fix behavior for F# and C#:

bug3.mp4

Note that our code does have a notion of multiple suggestions there. It just doesn't work.
@psfinaki psfinaki added Bug Area-LangService-CodeFixes Code fixes associated with diagnostics Needs-Triage labels Aug 28, 2023
@github-actions github-actions bot added this to the Backlog milestone Aug 28, 2023
This was referenced Aug 28, 2023
Open
Merged
@0101 0101 added Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Needs-Triage labels Sep 4, 2023
@psfinaki psfinaki self-assigned this Sep 7, 2023
@psfinaki psfinaki modified the milestones: Backlog, September-2023 Sep 7, 2023
@psfinaki psfinaki mentioned this issue Sep 19, 2023
Merged
@github-project-automation github-project-automation bot moved this from Not Planned to Done in F# Compiler and Tooling Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psfinaki psfinaki

Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
September-2023
Development

Successfully merging a pull request may close this issue.

Making code fixes generate multiple suggestions again psfinaki/fsharp
2 participants
@0101 @psfinaki