Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend RemoveSuperflousCaptureForUnionCaseWithNoDataProvider to cover literal patterns #15914

Open
Tracked by #15408
edgarfgp opened this issue Sep 1, 2023 · 0 comments
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics good first issue
Milestone

Comments

@edgarfgp
Copy link
Contributor

edgarfgp commented Sep 1, 2023

I notice that we can also use the same quick fix for FS3191: This literal pattern does not take arguments

type E =
     | A = 1
     | B = 2

 let (E.A x) = E.A

match E.A with
 | E.A x -> ()

let [<Literal>] A = 1

 match 1 with
 | (A x) -> ()

Originally posted by @edgarfgp in #14267 (comment)

@github-actions github-actions bot added this to the Backlog milestone Sep 1, 2023
@edgarfgp edgarfgp changed the title Extend RemoveSuperflousCaptureForUnionCaseWithNoDataProvider for literal patterns Extend RemoveSuperflousCaptureForUnionCaseWithNoDataProvider to cover literal patterns Sep 1, 2023
@psfinaki psfinaki added good first issue Area-LangService-CodeFixes Code fixes associated with diagnostics labels Sep 4, 2023
@psfinaki psfinaki mentioned this issue Sep 4, 2023
85 tasks
@0101 0101 removed the Needs-Triage label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics good first issue
Projects
Status: New
Development

No branches or pull requests

3 participants