Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined Module name gets colorized as blue when used to qualify a computation expression name #1697

Closed
cartermp opened this issue Nov 3, 2016 · 6 comments
Labels
Area-LangService-API Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. Regression

Comments

@cartermp
Copy link
Contributor

cartermp commented Nov 3, 2016

  1. Using the Roslyn editor on dev15prerel with .NET Desktop installed
  2. Clone FSharpx.Extras
  3. Change build targets of projects if they don't load, I just changed them to .NET Framework 4.6.1 and everything was fine
  4. Run paket.bootstrapper and then paket restore
  5. Open Lens.fs and go to line 58, noting that State.state is colorized blue, as if it were a keyword.

fs-wrong-color-type

However, the module State is user-defined:

fs-wrong-color-type-module

I'm not actually sure what the expected behavior here should be. Should the module be colorized at all as, say, teal? Should the name of the user-defined computation expression be colorized? cc @dsyme @Pilchie

@forki
Copy link
Contributor

forki commented Nov 3, 2016

please make sure that state (the one in lower case keeps be highlighted as keyword.

@OmarTawfik
Copy link
Contributor

@cartermp I wonder if that repros in Preview 5 (before rolsyn). No colorization logic was changed with RC?

@cartermp
Copy link
Contributor Author

cartermp commented Nov 4, 2016

@OmarTawfik I can try tomorrow, but this does have your type colorization work ('T and 'State are colorized in the second screenshot).

@cartermp
Copy link
Contributor Author

cartermp commented Nov 4, 2016

@OmarTawfik There's no coloring on dev14 Update 3 (No VFPT):

fs-dev14-no-color

So this is a bug. As far as resolution goes, if it's not a lot of work, then I think getting state colorized as @forki requests would be best. However if that seems like it's significant work, I think we should just replicate dev145 behavior and track colorizing computation expressions at the call site as up-for-grabs.

@OmarTawfik OmarTawfik assigned brettfo and unassigned OmarTawfik Nov 9, 2016
@cartermp cartermp added Regression Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels Nov 17, 2016
@vasily-kirichenko
Copy link
Contributor

In VS 2017 RC with VFPT installed it looks OK:

image

@cartermp cartermp changed the title User-defined Module name gets colorized as blue when used to quality a computation expression name User-defined Module name gets colorized as blue when used to qualify a computation expression name Dec 17, 2016
@cartermp cartermp added Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels Dec 17, 2016
@brettfo
Copy link
Member

brettfo commented Dec 21, 2016

Fixed by #2036.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-API Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. Regression
Projects
None yet
Development

No branches or pull requests

5 participants