Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness issue - Bar trivia in SynType.WithNull #17720

Closed
1 of 7 tasks
Tracked by #3118
nojaf opened this issue Sep 13, 2024 · 0 comments · Fixed by #17745
Closed
1 of 7 tasks
Tracked by #3118

Nullness issue - Bar trivia in SynType.WithNull #17720

nojaf opened this issue Sep 13, 2024 · 0 comments · Fixed by #17745
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage
Milestone

Comments

@nojaf
Copy link
Contributor

nojaf commented Sep 13, 2024

Issue description

Consider

type DU = MyCase of (string 
                        | // but why?
                            null)

Without having the range of |, we can't link the comment to the correct syntax node in Fantomas.
Would be great if we could have the range in the AST.

https://fsharp.github.io/fsharp-compiler-docs/reference/fsharp-compiler-syntax-syntype.html#WithNull

Choose one or more from the following categories of impact

  • Unexpected nullness warning (false positive in nullness checking, code uses --checknulls and langversion:preview).
  • Missing nullness warning in a case which can produce nulls (false negative, code uses --checknulls and langversion:preview).
  • Breaking change related to older null constructs in code not using the checknulls switch.
  • Breaking change related to generic code and explicit type constraints (null, not null).
  • Type inference issue (i.e. code worked without type annotations before, and applying the --checknulls enforces type annotations).
  • C#/F# interop issue related to nullness metadata.
  • Other (none of the categories above apply).

Operating System

Windows (Default)

What .NET runtime/SDK kind are you seeing the issue on

.NET SDK (.NET Core, .NET 5+)

.NET Runtime/SDK version

FCS 43.9.100-preview.24422.2

Reproducible code snippet and actual behavior

type DU = MyCase of (string 
                        | // but why?
                            null)

Possible workarounds

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Nullness Issues related to handling of Nullable Reference Types Bug Needs-Triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants