Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols: local functions don't provide parameter names and declaring type info #16542

Open
auduchinok opened this issue Jan 17, 2024 · 2 comments · May be fixed by #18124
Open

Symbols: local functions don't provide parameter names and declaring type info #16542

auduchinok opened this issue Jan 17, 2024 · 2 comments · May be fixed by #18124
Labels
Area-LangService-ToolTips tooltips/hover/quickinfo Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone
Backlog

Comments

@auduchinok
Copy link
Member

Extracts the case that is still broken from #13381.
Consider the following:

let f () =
    let c x = ()

    c

c symbol doesn't provide names for its parameters:

Screenshot 2024-01-17 at 13 54 28
@github-actions github-actions bot added this to the Backlog milestone Jan 17, 2024
@0101
Copy link
Contributor

0101 commented Jan 22, 2024

CC @psfinaki

@0101 0101 added Area-LangService-ToolTips tooltips/hover/quickinfo Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Needs-Triage labels Jan 22, 2024
@auduchinok
Copy link
Member Author

So the problem here is Val keeps the info we need in ValReprInfoForDisplay instead of ValReprInfo, so it's inaccessible in CurriedParameterGroups that the features use.

Is there a reason why these two are separate?
What would happen if we always put the info into ValReprInfo?

@auduchinok auduchinok linked a pull request Dec 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-ToolTips tooltips/hover/quickinfo Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
F# Compiler and Tooling
Status: New
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Symbols: try to use ValReprInfoForDisplay in Mfv.CurriedParameterGroups auduchinok/fsharp
2 participants
@0101 @auduchinok