Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickInfo tooltips should line wrap #1979

Closed
cartermp opened this issue Dec 9, 2016 · 8 comments · Fixed by #1981
Closed

QuickInfo tooltips should line wrap #1979

cartermp opened this issue Dec 9, 2016 · 8 comments · Fixed by #1981
Labels
Area-LangService-API Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.

Comments

@cartermp
Copy link
Contributor

cartermp commented Dec 9, 2016

On latest master, hover over a type with a very long sentence in its information, such as Async.FromBeginEnd.

Expected: Long summaries like this are line wrapped to ~100 chars or so.

Actual:

screen shot 2016-12-09 at 10 03 50 am

@cartermp cartermp added Area-LangService-API Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. labels Dec 9, 2016
@vasily-kirichenko
Copy link
Contributor

Does it look better?

image

@cartermp
Copy link
Contributor Author

cartermp commented Dec 9, 2016

@vasily-kirichenko Hmmm. I think it should still be shorter in width, but I'm seeing that C# does basically the same thing that you've got in your screenshot. I think that's fine for now.

@vasily-kirichenko
Copy link
Contributor

We can set any width for QuickInfo (but not for errors). This is what it looks like for width = 400 on 4K screen:

image

@cartermp
Copy link
Contributor Author

cartermp commented Dec 9, 2016

Yeah, I think the wrapped text like that can actually be worse. We'll probably have to re-evaluate tooltips for F# post-vs2017, but I think your PR which does the line wraps is good for vs2017.

Might be able to play around with width to see if we can shorten it to a point where no signatures wrap, but I wouldn't prioritize that.

@abelbraaksma
Copy link
Contributor

Expected: Long summaries like this are line wrapped to ~100 chars or so.

@cartermp, this is not just on the latest master. On VS2015, Update 3, with F# 4.0 (and, iirc also for older VS and older Updates), function summaries on one line are not linewrapped. For my own function library I added <para>, but this is obviously the wrong approach (as I need to remove them when creating online references).

Here it is on VS2015, Update 3, F# 4.0

Ugly tooltip

If this is somewhere configurable (however hidden it may be), that would be awesome. You can never predict what font sizes and window sizes other programmers are accustomed to.

I'd assume this won't be back-ported into the VS2015 branch of things?

(note 1: I thought I reported this previously, but couldn't find it back, big deja-vu feeling here)
(note 2: It may seem like a small bug, but it really makes using F# "feel" more mature, I think it is a two-thumbs-up improvement)
(note 3: C# has the same issue, iirc, but I've no problem in getting "better" than C# in editing experience)

@cartermp
Copy link
Contributor Author

@abelbraaksma Yeah, I think configurability is something we could investigate, and hopefully push further downstream so that C#/VB can benefit as well.

I'd assume this won't be back-ported into the VS2015 branch of things?

I don't think so, no. The mechanism behind tooltips is powered by Roslyn infrastructure that we only support in F# for vs2017 and onward. That's the plan for now, anyways.

@abelbraaksma
Copy link
Contributor

I can live with that, we can't keep living in the past anyways (I dread that I still have to maintain some projects in VS2010..., but that's totally OT here)

@cartermp
Copy link
Contributor Author

In my previous job I had to modify a web app in vs2005 🙂. Took a few days to get it to compile...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-API Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants