Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Rename does not work on non-private symbols on dirty buffers #2204

Closed
vasily-kirichenko opened this issue Jan 9, 2017 · 4 comments
Closed

Inline Rename does not work on non-private symbols on dirty buffers #2204

vasily-kirichenko opened this issue Jan 9, 2017 · 4 comments
Assignees
@0101
Labels
Area-LangService-RenameSymbol FCS and VS support for renaming symbols Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
October-2023

Comments

@vasily-kirichenko
Copy link
Contributor

vasily-kirichenko commented Jan 9, 2017 •
edited
Loading

image

image
@vasily-kirichenko
Copy link
Contributor Author

The bug is reproduced on dirty buffers only.

The feature uses ParseAndCheckProject here https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.Editor/Common/SymbolHelpers.fs#L44, which reads file contents from disk (via FileSystem class):

image

Project-wide diagnostics are not enabled due to the same bug, see #1856 (I've no idea why it's closed).

@cartermp cartermp added Area-LangService-API Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Jan 9, 2017
@cartermp cartermp added this to the VS 2017 RTM milestone Jan 9, 2017
@cartermp
Copy link
Contributor

cartermp commented Jan 9, 2017

Good catch. Hmmmm. This is definitely an important one to fix, but looking at the discussion in #1856 it seems that this may not make it into release. I'm still tagging as RTM though, since the importance of getting something like this fixed is high enough to warrant looking at it as an immediately-after-release issue.

@cartermp cartermp changed the title Inline Rename does not work on non-private symbols Inline Rename does not work on non-private symbols on dirty buffers Mar 15, 2017
@cartermp cartermp modified the milestones: VS 2017 Updates, VS 2017 RTM Apr 25, 2017
@dsyme dsyme added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Apr 29, 2017
@cartermp cartermp mentioned this issue Sep 22, 2017
Closed
@dsyme dsyme added Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. and removed Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels Sep 25, 2017
@dsyme dsyme added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Jan 29, 2018
@Zagrophyte Zagrophyte mentioned this issue May 17, 2018
Closed
@cartermp cartermp modified the milestones: VS 2017 Updates, 16.0 Jun 20, 2018
@cartermp cartermp mentioned this issue Aug 16, 2018
Closed
@cartermp cartermp mentioned this issue Dec 7, 2018
Closed
@cartermp cartermp modified the milestones: 16.0, 16.1 Feb 21, 2019
@cartermp cartermp modified the milestones: 16.1, 16.2 Apr 23, 2019
@cartermp cartermp modified the milestones: 16.2, Backlog Apr 30, 2019
@cartermp cartermp added Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. and removed Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels Aug 26, 2020
@cartermp
Copy link
Contributor

Updating to high severity since it makes rename useless for so many people. @TIHan has been investigating this.

@cartermp cartermp modified the milestones: Backlog, 16.9 Sep 8, 2020
@cartermp cartermp modified the milestones: 16.9, 16.10 Jan 6, 2021
@cartermp cartermp mentioned this issue Jan 6, 2021
Closed
10 tasks
@cartermp cartermp mentioned this issue Mar 2, 2021
Closed
7 tasks
@cartermp cartermp modified the milestones: 16.10, Backlog Apr 13, 2021
@KevinRansom KevinRansom added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Jul 7, 2021
@dsyme dsyme added Area-LangService-RenameSymbol FCS and VS support for renaming symbols and removed Area-LangService-API labels Apr 5, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Jun 17, 2022
@0101 0101 mentioned this issue Dec 12, 2022
Merged
@0101
Copy link
Contributor

0101 commented Jan 30, 2023

Fix is available as an opt-in setting, see #14033

@0101 0101 assigned 0101 and unassigned TIHan Jan 30, 2023
@0101 0101 mentioned this issue Oct 24, 2023
Merged
@0101 0101 modified the milestones: Backlog, October-2023 Oct 26, 2023
@0101 0101 closed this as completed Oct 26, 2023
@github-project-automation github-project-automation bot moved this from Future to Done in F# Compiler and Tooling Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0101 0101

Labels
Area-LangService-RenameSymbol FCS and VS support for renaming symbols Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
October-2023
Development

No branches or pull requests
6 participants
@0101 @vasily-kirichenko @TIHan @KevinRansom @cartermp @dsyme