Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert status bar changes implemented in #2683 #2787

Closed
saul opened this issue Apr 3, 2017 · 7 comments
Closed

Revert status bar changes implemented in #2683 #2787

saul opened this issue Apr 3, 2017 · 7 comments

Comments

@saul
Copy link
Contributor

saul commented Apr 3, 2017

Can we revert the status bar changes implemented in #2683? I understand that there are good intentions, but personally I think we should try to stick to standard VS behaviours as much as possible. I don't think it's unreasonable to think that many people using F# are in a mixed C#/F# codebase, and having distinct results for the same action (missing definition dialog in this instance) is more confusing than clarifying.

I'd just like to add that I'm really appreciative of the changes that @cloudRoutine implemented in that PR, I use the tooltips very often and it makes going back to VS 2015 even more painful. Keep it up guys :)

@cartermp
Copy link
Contributor

cartermp commented Apr 3, 2017

I agree - we should be loud and obvious about failure rather than not.

@KevinRansom
Copy link
Member

@cloudRoutine would you send a PR stripping out the status bar changes at issue, it would probably be preferable to reverting the whole PR. then have a discussion about the best way to incorporate those improvements.

Kevin

@cloudRoutine
Copy link
Contributor

there's no reason to take all of them out, first of all it doesn't disable the dialog box in all instances, second a few lines need to be changed to make it appear more often than it already does

@saul
Copy link
Contributor Author

saul commented Apr 3, 2017

@cloudRoutine sure, I can't speak for the rest of the guys but I'm happy with "Searching for symbol..." and the like. I just think the dialog box, as annoying as it is, at least makes failure obvious. 9pt text in the bottom left of my 30" screen is practically unnoticeable :(

@vasily-kirichenko
Copy link
Contributor

Originally we use the localized message from Roslyn resources.

@cloudRoutine
Copy link
Contributor

#2791

@vasily-kirichenko
Copy link
Contributor

@cartermp Can we close it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants