-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All features stop working on any file after solution is reloaded #2943
Comments
I'm not seeing this. I'm on master or very close to it I tried Close-Solution-Open-Solution - also edit-project-file-and-reload-solution Could you list a specific repro? |
I saw it every time as I switched between branches. Specifically between master and #2910 and back. |
Think this is another one fixed by my PR... |
I can report this bug too. However I'm not sure whether it's already fixed in the new master. |
@saul @vasily-kirichenko @cartermp We really need to get this and the other solution-reload bugs fixed. I spent some time looking but I don't have any idea what's going wrong. Does anyone know which PR caused this regression? |
This is the exception I see in the debugger after VFT solution was reloaded:
|
I think it's because we don't track open documents with the running document table. SetupNewTextView isn't called when the Solution is reloaded or when files are renamed. My PR moves us over to using the RDT but I'm not 100% sure that's what fixed this bug or if it was something else I changed that fixed it. I'll take another look tonight. |
I believe this is fixed by #3025, at least for solution reloads. At least it has worked for VisualFSharp.sln |
I confirm it's fixed in #3025 (I've tested on VFT and VFPT solutions). Thanks! |
I'll check that too, I've also seen before that it doesn't work if you have already opened a solution and a new F# project to it |
Fixed by #3025 |
Current master. Looks like a huge bug.
The text was updated successfully, but these errors were encountered: