Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS: Use VSSDK Pattern Matcher #4116

Closed
cartermp opened this issue Dec 14, 2017 · 4 comments
Closed

VS: Use VSSDK Pattern Matcher #4116

cartermp opened this issue Dec 14, 2017 · 4 comments
Labels
Area-VS VS support for F# not covered elsewhere Feature Improvement
Milestone

Comments

@cartermp
Copy link
Contributor

Starting with 15.6, the VS editor is going to have the Pattern Matcher available as an API. MyGet feed here.

This will allow us to remove our internal copy of Roslyn's version from a while ago, and will allow us to remove the dependency on FSharp.LanguageService.Base that FSharp.Editor has.

@forki
Copy link
Contributor

forki commented Dec 14, 2017 via email

@vasily-kirichenko
Copy link
Contributor

@forki it's used in Go to All feature to search symbols. I doubt anybody uses it though.

@cartermp
Copy link
Contributor Author

cartermp commented Dec 14, 2017

Also @forki earlier this year, @vasily-kirichenko ported it over (and some of its source-based dependencies) from Roslyn, because the Roslyn version was inaccessible with no plans to open it up. Since then, the editor team has forked the code, put it into the editor layer, and are exposing it for consumers starting with 15.6. Since they'll be maintaining this for all users of the assembly it'll be in, we should use that one moving forward.

@cartermp cartermp modified the milestones: 15.6, 15.7 Jan 20, 2018
@cartermp cartermp modified the milestones: 15.7, 15.8 Jun 8, 2018
@cartermp cartermp modified the milestones: 15.8, 16.0 Jun 20, 2018
@cartermp cartermp modified the milestones: 16.0, Unknown Aug 25, 2018
@dsyme dsyme added Area-VS VS support for F# not covered elsewhere and removed Area-LangService-API labels Apr 6, 2022
@dsyme dsyme changed the title Use VSSDK Pattern Matcher VS: Use VSSDK Pattern Matcher Apr 6, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Jun 17, 2022
@majocha
Copy link
Contributor

majocha commented Mar 26, 2023

Done in #14746.

@github-project-automation github-project-automation bot moved this from Not Planned to Done in F# Compiler and Tooling Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VS VS support for F# not covered elsewhere Feature Improvement
Projects
Archived in project
Development

No branches or pull requests

6 participants