Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit restore doesn't restore enough #5241

Closed
0x53A opened this issue Jun 27, 2018 · 5 comments
Closed

Implicit restore doesn't restore enough #5241

0x53A opened this issue Jun 27, 2018 · 5 comments

Comments

@0x53A
Copy link
Contributor

0x53A commented Jun 27, 2018

EDIT: running dotnet restore on the console fixed it.

The following behavior is on my work pc with VS2017.7.3.
I can't try it on my home pc with VS 2018.8pre because I currently don't have internet there. 😱

Would appreciate guidance on whether this is a known fixed bug (can't currently test on 15.7.4 or 15.8.x), whether you can reproduce it, and if there are any workarounds.

  1. Clone https://github.com/haf/expecto, checkout master.

Notice that nuget shows warnings
grafik
and almost nothing works.

Colorization is just the basic one, no class-coloring (I guess DateTime should be blue), no tooltips, no intellisense:
grafik

  1. I added explicit references to System.ValueTuple (https://github.com/0x53A/expecto/tree/valuetuple), which removed the NuGet warnings, but didn't bring the tooling back to life.

  2. New Project -> F# -> Class Library (.NET Standard)

Everything works
grafik


VS and .NET SDK:

grafik

C:\Repos\expecto>dotnet --info
.NET Core SDK (reflecting any global.json):
 Version:   2.1.301
 Commit:    59524873d6

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.16299
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.301\

Host (useful for support):
  Version: 2.1.1
  Commit:  6985b9f684

.NET Core SDKs installed:
  2.1.201 [C:\Program Files\dotnet\sdk]
  2.1.301 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.7 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download
@0x53A
Copy link
Contributor Author

0x53A commented Jun 27, 2018

grr, running dotnet restore on the console fixed it.

I'll still leave it open, as the implicit restore should work.

@0x53A 0x53A changed the title Almost no tooling in Expecto Solution Implicit restore doesn't restore enough Jun 27, 2018
@cartermp
Copy link
Contributor

cartermp commented Jun 27, 2018

Closing this as external, since this isn't a F# tooling issue. I'd suggest opening this on dotnet/project-system, which is where implicit restore at design time is handled.

@0x53A
Copy link
Contributor Author

0x53A commented Jun 27, 2018

Expecto uses paket, so it seems like I've hit the scenario you described here: fsprojects/Paket#3270 (comment)

@0x53A
Copy link
Contributor Author

0x53A commented Jul 25, 2018

I don't have a repro, which is why I haven't opened another issue, but I've hit a similar issue again. Vanilla nuget, no paket.

Open project, I get basic features, but no extended features.
Restart VS, everything works.

@0x53A
Copy link
Contributor Author

0x53A commented Jul 25, 2018

dotnet/project-system#3788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants