Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various codegen tests failing #918

Closed
latkin opened this issue Jan 30, 2016 · 3 comments
Closed

Various codegen tests failing #918

latkin opened this issue Jan 30, 2016 · 3 comments

Comments

@latkin
Copy link
Contributor

latkin commented Jan 30, 2016

I'm seeing the following failures on master. Have not dug in to see what the delta is.

Optimizations\GenericComparison #  (Compare07.fs - NetFx40)
Optimizations\GenericComparison #  (Compare10.fs - NetFx40)
Optimizations\GenericComparison #  (Equals06.fs - NetFx40)
Optimizations\GenericComparison #  (Equals09.fs - NetFx40)
Optimizations\GenericComparison #  (Hash09.fs - NetFx40)
Optimizations\GenericComparison #  (Hash12.fs - NetFx40)
@manofstick
Copy link
Contributor

I dare say that would be #513 - that was slurped in relatively recently? Lots of stuff around equality gets inlined, so it could end up with different codegen? But I see green on master build? Are you doing something extra?

@dsyme
Copy link
Contributor

dsyme commented Feb 7, 2016

@manofstick Not all tests are run by CI. I'm going to track all current test failures on master with bug #915 and close this.

@dsyme dsyme closed this as completed Feb 7, 2016
@dsyme
Copy link
Contributor

dsyme commented Feb 7, 2016

@manofstick Please see #944 (comment) and take a careful look at the tailcalls that have been removed.

For example this one: https://github.com/Microsoft/visualfsharp/pull/944/files#diff-60d0249459018d317436fa8662d9701eL598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants