Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies of netfx PackageReferences aren't referenced #78

Closed
jnm2 opened this issue Sep 13, 2018 · 5 comments
Closed

Dependencies of netfx PackageReferences aren't referenced #78

jnm2 opened this issue Sep 13, 2018 · 5 comments
Milestone

Comments

@jnm2
Copy link

jnm2 commented Sep 13, 2018

I'm referencing DevExpress's NuGet packages which target net40 in a netcoreapp3.0 project using <FrameworkReference Include="Microsoft.DesktopUI" />. NuGet gives a warning but everything should restore fine. From BUILD and dotnetconf, the expectation is that many .NET Framework assemblies actually do just work for the time being.

However, the compiler isn't referencing any assemblies from the package dependencies of these packages. In order to get the compiler to see assemblies in the package graph, I have to directly reference every package in the tree.

These packages come from a private feed with DevExpress customer API token in the URL, but there's nothing unusual about them.

Here's the workaround for now:

  <ItemGroup>
    <!-- ... -->
    <PackageReference Include="DevExpress.Win.Reporting" Version="17.2.4" />
    <PackageReference Include="DevExpress.Win.SpellChecker" Version="17.2.4" />
    <!-- ... -->
  </ItemGroup>

  <ItemGroup Label="Workaround for broken transitive restore (https://github.com/dotnet/core-sdk/issues/78)">
    <!-- Direct dependency of both DevExpress.Win.Reporting and DevExpress.Win.SpellChecker -->
    <PackageReference Include="DevExpress.Win" Version="17.2.4" />
    <!-- Direct dependencies of DevExpress.Win.Reporting -->
    <PackageReference Include="DevExpress.Win.Charts" Version="17.2.4" />
    <PackageReference Include="DevExpress.Reporting.Core" Version="17.2.4" />
    <PackageReference Include="DevExpress.Utils.UI" Version="17.2.4" />
    <!-- Direct dependency of DevExpress.Win.Reporting, DevExpress.Win.Charts, and DevExpress.Reporting.Core -->
    <PackageReference Include="DevExpress.Charts" Version="17.2.4" />
      <!-- Direct dependency of DevExpress.Win.Reporting, DevExpress.Win.Charts, and DevExpress.Charts -->
    <PackageReference Include="DevExpress.Charts.Core" Version="17.2.4" />
    <!-- Direct dependency of DevExpress.Win.Reporting and DevExpress.Utils.UI -->
    <PackageReference Include="DevExpress.Win.RichEdit" Version="17.2.4" />
    <!-- Direct dependencies of DevExpress.Win, DevExpress.Win.Reporting, and DevExpress.Reporting.Core -->
    <PackageReference Include="DevExpress.PivotGrid.Core" Version="17.2.4" />
    <PackageReference Include="DevExpress.RichEdit.Core" Version="17.2.4" />
    <!-- Direct dependencies of many of the above -->
    <PackageReference Include="DevExpress.Data" Version="17.2.4" />
    <PackageReference Include="DevExpress.Utils" Version="17.2.4" />
  </ItemGroup>
@nguerrera
Copy link

Does the nuspec rendering of the package to package dependencies have exclude=compile?

Do you have a repro using packages that we can access?

@nguerrera nguerrera added this to the Discussion milestone Jan 21, 2019
@nguerrera
Copy link

@jnm2 Friendly ping on those questions. If there are exclude=compile in the nuspecs of these packages, this is by design. If they do not, I'll need a repro to investigate further.

@nguerrera
Copy link

Duplicate of NuGet/Home#5957

@jnm2
Copy link
Author

jnm2 commented Apr 17, 2019

@nguerrera I'm so sorry I didn't get to this. Glad it was an existing problem and not something new.

@nguerrera
Copy link

No problem! I happened upon that nuget issue and then it hit me that this is the same as that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants