Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to WinRT with Microsoft.Windows.SDK.NET #1091

Closed
krwq opened this issue May 28, 2020 · 2 comments · Fixed by #1217
Closed

Replace references to WinRT with Microsoft.Windows.SDK.NET #1091

krwq opened this issue May 28, 2020 · 2 comments · Fixed by #1217
Labels
bug Something isn't working

Comments

@krwq
Copy link
Member

krwq commented May 28, 2020

Per #1089 (comment) WinRT will not have a builtin runtime support and will cause our library to likely stop working on Windows after 5.0 ships.

Per @jkoritzinsky:

The way to migrate is to remove all references to winmds and System.Runtime.WindowsRuntime and System.Runtime.InteropServices.WindowsRuntime and instead just reference the Microsoft.Windows.SDK.NET package.

@krwq krwq added the bug Something isn't working label May 28, 2020
@krwq krwq added this to the vNext milestone May 28, 2020
@joperezr
Copy link
Member

I tried doing this and found a blocker because of issue microsoft/CsWinRT#338 since that Windows SDK package is not currently strong-named signed. Once they fix that issue, we can come back and continue this work

@pgrawehr
Copy link
Contributor

pgrawehr commented Oct 2, 2020

@joperezr : microsoft/CsWinRT#338 is fixed. So you might want to give it another try.

@joperezr joperezr added blocking-release and removed blocked Issue/PR is blocked on something - see comments labels Oct 14, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants