Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move samples projects to .NET 5.0 #1190

Closed
richlander opened this issue Sep 21, 2020 · 5 comments · Fixed by #1224
Closed

Move samples projects to .NET 5.0 #1190

richlander opened this issue Sep 21, 2020 · 5 comments · Fixed by #1224
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation untriaged

Comments

@richlander
Copy link
Member

We should decide when we can do this. Can we do it now? Wait until .NET 5.0 RTM?

It would be really nice to move all of the samples to top-level programs, for example.

What do people think that use this repo? Do you use the samples (both at https://github.com/dotnet/iot/tree/master/samples and the ones that exist in samples directories at https://github.com/dotnet/iot/tree/master/src/devices)?

@richlander richlander added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Sep 21, 2020
@Ellerbach
Copy link
Member

Can we do it now?

You can always prepare everything...

Wait until .NET 5.0 RTM?

...and push the PR once .NET 5.0 is final.

And if you update, better update everything for consistency. At least it will be easier.

@shaggygi
Copy link
Contributor

It would be really nice to move all of the samples to top-level programs, for example.

Don't quite understand the comment. Do you mean move all binding samples to https://github.com/dotnet/iot/tree/master/samples? If so, I disagree. It seems to be better to keep the binding samples within respective binding folder. That allows it to be discovered easier and updated when changes or new features occur.

As for https://github.com/dotnet/iot/tree/master/samples, this is a good location for newbies to get a quick sense of using APIs.

@krwq
Copy link
Member

krwq commented Sep 22, 2020

I agree with @shaggygi that it's much easier to find when they are local to the project. What we can do is perhaps generate part of https://github.com/dotnet/iot/blob/master/samples/README.md to point to samples/READMEs from devices

@pgrawehr
Copy link
Contributor

@richlander : Due to #1099, the entire library currently is not working with .NET Core 5, preview 5 or later. So unless you use preview 4, you'll have a hard time converting anything to .NET 5.

@richlander
Copy link
Member Author

I wasn't proposing to move the samples from the binding folder. I also agree that we should not do that and they are best where they are.

@pgrawehr -- this is due to a breaking change w/rt to WinRT, related to #1193. 5.0 samples should now be resolved.

Once my open NRTs people gets merged, I'll create a PR for updating the samples.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants