Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share warning codes with roslyn analyzers #1393

Closed
sbomer opened this issue Jul 30, 2020 · 0 comments
Closed

Share warning codes with roslyn analyzers #1393

sbomer opened this issue Jul 30, 2020 · 0 comments

Comments

@sbomer
Copy link
Member

sbomer commented Jul 30, 2020

Some of the analysis we want to do can be done either in a Roslyn analyzer or in the linker. The plan is for these to share warning codes, so that a given warning can be disabled for both Roslyn and linker analyzers via NoWarn, etc.

Ideally we would share some of the analysis infrastructure and warnings to begin with - but in the meantime, we should avoid using the following codes for other linker warnings.

Introduced by https://github.com/dotnet/roslyn-analyzers/pull/3921/files:

  • IL3000: System.Reflection.Assembly.Location' always returns an empty string for assemblies embedded in a single-file app. If the path to the app directory is needed, consider calling 'System.AppContext.BaseDirectory'.
  • IL3001: Assemblies embedded in a single-file app cannot have additional files in the manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants