PR feedback.

Author: codemzs

src/Microsoft.ML/Models/BinaryClassificationEvaluator.cs

@@ -72,7 +72,7 @@ public BinaryClassificationMetrics Evaluate(PredictionModel model, ILearningPipe
 
                 Contracts.Assert(metric.Count == 1);
 
-                return metric.First();
+                return metric[0];
             }
         }
     }

src/Microsoft.ML/Models/ClassificationEvaluator.cs

@@ -72,7 +72,7 @@ public ClassificationMetrics Evaluate(PredictionModel model, ILearningPipelineLo
 
                 Contracts.Assert(metric.Count == 1);
 
-                return metric.First();
+                return metric[0];
             }
         }
     }

src/Microsoft.ML/Models/CrossValidator.cs

@@ -116,31 +116,31 @@ public CrossValidationOutput<TInput, TOutput> CrossValidate<TInput, TOutput>(Lea
 
                 experiment.Run();
 
-                CrossValidationOutput<TInput, TOutput> cvo = new CrossValidationOutput<TInput, TOutput>();
-                cvo.PredictorModels = new PredictionModel<TInput, TOutput>[NumFolds];
+                var cvOutput = new CrossValidationOutput<TInput, TOutput>();
+                cvOutput.PredictorModels = new PredictionModel<TInput, TOutput>[NumFolds];
 
                 for (int Index = 0; Index < NumFolds; Index++)
                 {
 
                     if (Kind == MacroUtilsTrainerKinds.SignatureBinaryClassifierTrainer)
                     {
-                        cvo.BinaryClassificationMetrics = BinaryClassificationMetrics.FromMetrics(
+                        cvOutput.BinaryClassificationMetrics = BinaryClassificationMetrics.FromMetrics(
                             environment,
                             experiment.GetOutput(crossValidateOutput.OverallMetrics),
                             experiment.GetOutput(crossValidateOutput.ConfusionMatrix),
                             2);
                     }
                     else if(Kind == MacroUtilsTrainerKinds.SignatureMultiClassClassifierTrainer)
                     {
-                        cvo.ClassificationMetrics = ClassificationMetrics.FromMetrics(
+                        cvOutput.ClassificationMetrics = ClassificationMetrics.FromMetrics(
                             environment,
                             experiment.GetOutput(crossValidateOutput.OverallMetrics),
                             experiment.GetOutput(crossValidateOutput.ConfusionMatrix),
                             2);
                     }
                     else if (Kind == MacroUtilsTrainerKinds.SignatureRegressorTrainer)
                     {
-                        cvo.RegressionMetrics = RegressionMetrics.FromOverallMetrics(
+                        cvOutput.RegressionMetrics = RegressionMetrics.FromOverallMetrics(
                             environment,
                             experiment.GetOutput(crossValidateOutput.OverallMetrics),
                             2);
@@ -161,11 +161,11 @@ public CrossValidationOutput<TInput, TOutput> CrossValidate<TInput, TOutput>(Lea
 
                         predictor = environment.CreateBatchPredictionEngine<TInput, TOutput>(memoryStream);
 
-                        cvo.PredictorModels[Index] = new PredictionModel<TInput, TOutput>(predictor, memoryStream);
+                        cvOutput.PredictorModels[Index] = new PredictionModel<TInput, TOutput>(predictor, memoryStream);
                     }
                 }
 
-                return cvo;
+                return cvOutput;
             }
         }
     }

src/Microsoft.ML/Models/RegressionEvaluator.cs

@@ -67,7 +67,7 @@ public RegressionMetrics Evaluate(PredictionModel model, ILearningPipelineLoader
 
                 Contracts.Assert(metric.Count == 1);
 
-                return metric.First();
+                return metric[0];
             }
         }
     }

src/Microsoft.ML/Models/TrainTestEvaluator.cs

@@ -119,8 +119,7 @@ public TrainTestEvaluatorOutput<TInput, TOutput> TrainTestEvaluate<TInput, TOutp
 
                 experiment.Run();
 
-                TrainTestEvaluatorOutput<TInput, TOutput> trainTestOutput = new TrainTestEvaluatorOutput<TInput, TOutput>();
-                
+                var trainTestOutput = new TrainTestEvaluatorOutput<TInput, TOutput>();
                 if (Kind == MacroUtilsTrainerKinds.SignatureBinaryClassifierTrainer)
                 {
                     trainTestOutput.BinaryClassificationMetrics = BinaryClassificationMetrics.FromMetrics(

src/Microsoft.ML/Runtime/EntryPoints/CrossValidationMacro.cs

@@ -294,7 +294,8 @@ public static CommonOutputs.MacroOutput<Output> CrossValidate(
                 var confusionMatrix = new Var<IDataView>();
                 outputMap.Add(nameof(TrainTestMacro.Output.ConfusionMatrix), confusionMatrix.VarName);
                 confusionMatrixVars[k] = confusionMatrix;
-                subGraphNodes.Add(EntryPointNode.Create(env, "Models.TrainTestEvaluator", args, node.Catalog, node.Context, inputBindingMap, inputMap, outputMap));
+                const string trainTestEvaluatorMacroEntryPoint = "Models.TrainTestEvaluator";
+                subGraphNodes.Add(EntryPointNode.Create(env, trainTestEvaluatorMacroEntryPoint, args, node.Catalog, node.Context, inputBindingMap, inputMap, outputMap));
             }
 
             exp.Reset();