Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastTree Ranking revert gradient calculation to native code #412

Closed
TomFinley opened this issue Jun 26, 2018 · 0 comments
Closed

FastTree Ranking revert gradient calculation to native code #412

TomFinley opened this issue Jun 26, 2018 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TomFinley
Copy link
Contributor

Currently the FastTree ranking code has an #if to control whether it uses native or .NET code, as declared here.

<DefineConstants>$(DefineConstants);USE_FASTTREENATIVE;NO_STORE;CORECLR</DefineConstants>

Normally this takes the form of #if USE_FASTTREENATIVE, except for here.

That 2, I'm somewhat embarrassed to report, is an unintentional mistake I made some time ago. It was part of a change involving some hundreds of files, and I think I just made a small error.

Now, somehow, this didn't get noticed. It however differs in its support of a few arguments. These arguments are hidden and not recommended to be used for general users, but nonetheless they may be important, and having it not be supported was unintentional.

if (_useShiftedNdcg || _costFunctionParam == 'c' || _distanceWeight2 || _normalizeQueryLambdas)
{
throw new Exception("Shifted NDCG / ContinuousWeightedRanknet / distanceWeight2 / normalized lambdas are only supported by unmanaged code");
}

This is not to say we shouldn't shift to not use the native library, but I'd rather it be done in a controlled fashion to ensure compatibility (which this thing does not do), rather than unintentionally as I did here.

This issue is directly relevant to @najeeb-kazmi and @rogancarr .

@TomFinley TomFinley self-assigned this Jun 26, 2018
@shauheen shauheen added the bug Something isn't working label Jun 26, 2018
@shauheen shauheen added this to the 0618 milestone Jun 26, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants