Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Onnx path parameter mandatory in OnnxConverter #423

Closed
zeahmed opened this issue Jun 26, 2018 · 0 comments · Fixed by #641
Closed

Make Onnx path parameter mandatory in OnnxConverter #423

zeahmed opened this issue Jun 26, 2018 · 0 comments · Fixed by #641
Assignees
Labels
bug Something isn't working
Milestone

Comments

@zeahmed
Copy link
Contributor

zeahmed commented Jun 26, 2018

According to the documentation, both Onnx and Json paths are optional. Make at least Onnx path mandatory for conversion.

https://github.com/dotnet/machinelearning/blob/master/src/Microsoft.ML/Models/OnnxConverter.cs

OnnxConverter converter = new OnnxConverter()
{
    InputsToDrop = new[] { "Label" },
    OutputsToDrop = new[] { "Label", "Features" },
    Onnx = onnxPath,
    Json = onnxAsJsonPath,
    Domain = "Onnx"
};

converter.Convert(model);
@shauheen shauheen added the bug Something isn't working label Jun 28, 2018
@shauheen shauheen added this to the 0718 milestone Jun 28, 2018
@codemzs codemzs self-assigned this Jul 10, 2018
@shauheen shauheen modified the milestones: 0718, 0818 Aug 4, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants