-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweepable Parameter can't handle Russia Format #4634
Comments
I would fix by pushing a culture invariant into the sweepable param:
|
In that case we need to add culture invariant to whichever parse from /into string in AutoML. Either we stick to one culture preference inside AutoML, or we just use the default culture setting. Do you remember the story why we add that culture invariant restriction when parsing sweepable params.. |
I would stick w/ culture invariant for the lifetime of the string. Currently we have culture invariant on the use of the string, but not the creation. Hence this issue being filed. Using culture invariant helps in various ways:
|
OK that's convincing, thanks |
If, for example, in SweepableFloatParam, the raw text value is 0,00123454, it will be parsed into 123454 instead of 0.00123454
See this Issue for further details
The text was updated successfully, but these errors were encountered: