You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
michaelgsharp opened this issue
Apr 26, 2021
· 1 comment
Labels
loadsaveBugs related loading and saving data or modelsonnxExporting ONNX models or loading ONNX modelsP1Priority of the issue for triage purpose: Needs to be fixed soon.
Right now when we use an ONNX model that is saved inside an ML.NET model, we create a new temp file for the ONNX model. This temp file is only cleaned up if the user manually calls dispose on the loaded ML.NET model. This is a problem because the base ITransformer that is loaded from Model.Load is not disposable. You need to know you have to manually cast it to IDisposable to dispose of it correctly. It also is a problem because the temp file name is not recorded anywhere (other than inside the class itself), so its hard to manually clean it up as well.
The text was updated successfully, but these errors were encountered:
michaelgsharp
added
P1
Priority of the issue for triage purpose: Needs to be fixed soon.
onnx
Exporting ONNX models or loading ONNX models
loadsave
Bugs related loading and saving data or models
labels
Apr 26, 2021
ghost
locked as resolved and limited conversation to collaborators
Mar 17, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
loadsaveBugs related loading and saving data or modelsonnxExporting ONNX models or loading ONNX modelsP1Priority of the issue for triage purpose: Needs to be fixed soon.
Right now when we use an ONNX model that is saved inside an ML.NET model, we create a new temp file for the ONNX model. This temp file is only cleaned up if the user manually calls dispose on the loaded ML.NET model. This is a problem because the base
ITransformer
that is loaded fromModel.Load
is not disposable. You need to know you have to manually cast it toIDisposable
to dispose of it correctly. It also is a problem because the temp file name is not recorded anywhere (other than inside the class itself), so its hard to manually clean it up as well.The text was updated successfully, but these errors were encountered: