Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Clean up item related to Tokenizers #7268

Open
tarekgh opened this issue Oct 10, 2024 · 0 comments
Open

[Tracking] Clean up item related to Tokenizers #7268

tarekgh opened this issue Oct 10, 2024 · 0 comments

Comments

@tarekgh
Copy link
Member

tarekgh commented Oct 10, 2024

In the PR #7264 we have added dependency on the Microsoft.Bcl.Memory which was not released as GA yet. This issue is tracking the tracking to clean up the following two items:

  • Microsoft.Bcl.Memory will produce a warning in any project targeting net6. As we still have some projects targeting net6, we had to add the property <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the projects to avoid the warning. When we do the retargeting/upgrade such projects, we need to remove the added property.
  • As Microsoft.Bcl.Memory not released and we are referencing the preview version of this package, we need to change that after the package became GA.
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged label Oct 10, 2024
@tarekgh tarekgh added this to the ML.NET Future milestone Oct 10, 2024
@tarekgh tarekgh added Tokenizers and removed untriaged New issue has not been triaged labels Oct 10, 2024
@tarekgh tarekgh mentioned this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant