Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CpuMath: Sse code is executed when Avx is available, except on .NET Core 3.0 #80

Closed
helloguo opened this issue May 8, 2018 · 5 comments

Comments

@helloguo
Copy link

helloguo commented May 8, 2018

System information

  • Windows 10 Enterprise:
  • dotnet Version: 2.1.105:

Issue

@danmoseley
Copy link
Member

This relates to the native code implementation, which is used on .NET Core 2.1 and .NET Framework.

Note Avx.cpp, which as this issue points out was dead, was removed in 263a67b. I do not think there are plans to bring it back and wire it up, although it could be.

@danmoseley danmoseley changed the title CpuMath: Sse code is executed when Avx is available CpuMath: Sse code is executed when Avx is available, except on .NET Core 3.0 Oct 29, 2018
@helloguo
Copy link
Author

Thank you for explaining. Closing this issue if there is no other concern,

@danmoseley danmoseley reopened this Oct 29, 2018
@danmoseley
Copy link
Member

I think it's fine to have the issue open, in case someone has the (considerable) motivation to enable AVX support in the native code. (Starting by undeleting the file, then wiring it up as needed, with perf measurements and tests.)

@helloguo
Copy link
Author

Adding AVX CPP implementation would benefit Full Framework, which has no C# HW Intrinsic available today. I guess it really depends on the scenarios and how often people use Full Framework vs .NET Core when developing and deploying ML.NET applications.

@codemzs
Copy link
Member

codemzs commented Jun 30, 2019

closing this issue as there is no plan to enable AVX support in the short-term. In the short term our goals are around ONNX, AutoML and DNN training scenarios.

@codemzs codemzs closed this as completed Jun 30, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants