FastTreeRankingTrainer expose non-advanced args(#1246) #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfilipi
reviewed
Oct 26, 2018
| string groupIdColumn = null, | ||
| int numLeaves = Defaults.NumLeaves, | ||
| int numTrees = Defaults.NumTrees, | ||
| int minDocumentsInLeafs = Defaults.MinDocumentsInLeafs, |
There was a problem hiding this comment.
= Defaults.MinDocumentsInLeafs [](start = 35, length = 31)
please remove defaults from the base classes
sfilipi
reviewed
Oct 26, 2018
| string featureColumn, | ||
| string weightColumn = null, | ||
| string groupIdColumn = null, | ||
| int numLeaves = Defaults.NumLeaves, |
There was a problem hiding this comment.
= Defaults.NumLeaves [](start = 25, length = 21)
same here; remove defaults
sfilipi
reviewed
Oct 26, 2018
| protected RandomForestTrainerBase(IHostEnvironment env, SchemaShape.Column label, string featureColumn, | ||
| string weightColumn = null, string groupIdColumn = null, bool quantileEnabled = false, Action<TArgs> advancedSettings = null) | ||
| : base(env, label, featureColumn, weightColumn, groupIdColumn, advancedSettings) | ||
| : base(env, label, featureColumn, weightColumn, groupIdColumn, advancedSettings: advancedSettings) |
There was a problem hiding this comment.
advancedSettings: advancedSettings) [](start = 75, length = 35)
did you want to add the other args?
sfilipi
reviewed
Oct 26, 2018
| /// <param name="weightColumn">The name for the column containing the initial weight.</param> | ||
| /// <param name="advancedSettings">A delegate to apply all the advanced arguments to the algorithm.</param> | ||
| public FastTreeTweedieTrainer(IHostEnvironment env, string labelColumn, string featureColumn, | ||
| string groupIdColumn = null, string weightColumn = null, Action<Arguments> advancedSettings = null) |
There was a problem hiding this comment.
null, Action advancedSettings = null [](start = 63, length = 47)
would you like to add the other args
|
Thanks for the help @feiyun0112. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1246
add
numLeaves,numTrees,minDocumentsInLeafs,learningRateargs