Skip to content

[PassKit] Added support for Xcode 10 up to beta 3. #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dalexsoto merged 2 commits into from
Jul 14, 2018
Merged

[PassKit] Added support for Xcode 10 up to beta 3. #4423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a62df7
[PassKit] Added support for Xcode 10 up to beta 3.
mandel-macaque Jul 10, 2018
44115c5
Minor style changes.
mandel-macaque Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/PassKit/PKEnums.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,12 @@ public enum PKPaymentErrorCode : long {
BillingContactInvalid,
ShippingAddressUnserviceable,
}

[iOS (12,0)]
[NoWatch]
[Native]
public enum PKAddPaymentPassStyle : ulong {
Payment,
Access,
}
}
20 changes: 20 additions & 0 deletions src/passkit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,10 @@ interface PKAddPaymentPassRequestConfiguration : NSSecureCoding
[NoWatch] // Radar: https://trello.com/c/MvaHEZlc
[Export ("requiresFelicaSecureElement")]
bool RequiresFelicaSecureElement { get; set; }

[iOS (12, 0)]
Copy link
Contributor

@spouliot spouliot Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing [NoWatch] here - the enum type has the attribute

[Export ("style", ArgumentSemantic.Assign)]
PKAddPaymentPassStyle Style { get; set; }
}

[iOS (9,0)]
Expand Down Expand Up @@ -838,6 +842,18 @@ interface PKPaymentNetwork {
[iOS (10,3), Watch (3,2)]
[Field ("PKPaymentNetworkIDCredit")]
NSString IDCredit { get; }

[iOS (12,0), Watch (5,0)]
[Field ("PKPaymentNetworkElectron")]
NSString Electron { get; }

[iOS (12,0), Watch (5,0)]
[Field ("PKPaymentNetworkMaestro")]
NSString Maestro { get; }

[iOS (12,0), Watch (5,0)]
[Field ("PKPaymentNetworkVPay")]
NSString VPay { get; }
}

#if !WATCH
Expand All @@ -855,6 +871,10 @@ interface PKPaymentButton {
[Export ("initWithPaymentButtonType:paymentButtonStyle:")]
[DesignatedInitializer]
IntPtr Constructor (PKPaymentButtonType type, PKPaymentButtonStyle style);

[iOS (12, 0)]
[Export ("cornerRadius")]
nfloat CornerRadius { get; set; }
}

[iOS (9,0)]
Expand Down
9 changes: 0 additions & 9 deletions tests/xtro-sharpie/iOS-PassKit.todo
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions tests/xtro-sharpie/watchOS-PassKit.todo
View file
Open in desktop

This file was deleted.