[Android] Removing outdated menu items as Android can delete them after switching activities (#28767)

* Fixing issue #24357 by removing outdated menu items as Android can delete them after switching activities

* Disposing outdated IMenuItem just in case

* Reduced memory allocation

* Tuned performance a bit

Author: VitalyKnyazev

src/Controls/src/Core/Platform/Android/Extensions/ToolbarExtensions.cs

@@ -232,9 +232,22 @@ public static void UpdateMenuItems(this AToolbar toolbar,
 			if (sortedToolbarItems == null || previousMenuItems == null)
 				return;
 
-			var context = mauiContext.Context;
 			var menu = toolbar.Menu;
 
+			// menu items can be deleted by Android after switching activities, removing outdated menu items first
+			if (menu != null)
+			{
+				for (var j = previousMenuItems.Count - 1; j >= 0; j--)
+				{
+					var previousMenuItem = previousMenuItems[j];
+					if (menu.FindItem(previousMenuItem.ItemId) == null)
+					{
+						previousMenuItem.Dispose();
+						previousMenuItems.RemoveAt(j);
+					}
+				}
+			}
+
 			foreach (var toolbarItem in previousToolBarItems)
 				toolbarItem.PropertyChanged -= toolbarItemChanged;