Skip to content

Commit 38cfae7

Browse files
PureWeenrmarinho
authored andcommitted
- fix based on review comments
1 parent ad07982 commit 38cfae7

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28986_NavigationPage.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public void ToolbarExtendsAllTheWayLeftAndRight_NavigationPage()
2222
App.SetOrientationLandscape();
2323
App.WaitForElement("ContentGrid");
2424
VerifyScreenshot();
25-
App.SetOrientationPortrait();
2625
}
2726
}
2827
#endif

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28986_Shell.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public void ToolbarExtendsAllTheWayLeftAndRight_Shell()
2222
App.SetOrientationLandscape();
2323
App.WaitForElement("ContentGrid");
2424
VerifyScreenshot();
25-
App.SetOrientationPortrait();
2625
}
2726
}
2827
#endif

src/Controls/tests/TestCases.Shared.Tests/UITest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,8 @@ but both can happen.
243243
environmentName = "android-notch-36";
244244
}
245245

246-
if (!((deviceApiLevel == 30 && (deviceScreenSize == "1080x1920" || deviceScreenSize == "1920X1080" ) && deviceScreenDensity == 420) ||
247-
(deviceApiLevel == 36 && (deviceScreenSize == "1080x2424" || deviceScreenSize == "2424x1080") && deviceScreenDensity == 420)))
246+
if (!((deviceApiLevel == 30 && (deviceScreenSize.Equals("1080x1920", StringComparison.OrdinalIgnoreCase) || deviceScreenSize.Equals("1920x1080", StringComparison.OrdinalIgnoreCase)) && deviceScreenDensity == 420) ||
247+
(deviceApiLevel == 36 && (deviceScreenSize.Equals("1080x2424", StringComparison.OrdinalIgnoreCase) || deviceScreenSize.Equals("2424x1080", StringComparison.OrdinalIgnoreCase)) && deviceScreenDensity == 420)))
248248
{
249249
Assert.Fail($"Android visual tests should be run on an API30 emulator image with 1080x1920 420dpi screen or API36 emulator image with 1080x2424 420dpi screen, but the current device is API {deviceApiLevel} with a {deviceScreenSize} {deviceScreenDensity}dpi screen. Follow the steps on the MAUI UI testing wiki to launch the Android emulator with the right image.");
250250
}

0 commit comments

Comments
 (0)