[Testing] Enabling some UITests from Issues folder in Appium-3 (#27065)

* Migrated the eight issues

* Updated Issue7338.cs

Author: nivetha-nagalingam

src/Controls/tests/TestCases.HostApp/Issues/Issue2929.cs

@@ -25,51 +25,4 @@ protected override void Init()
 			};
 		}
 	}
-
-
-	[Issue(IssueTracker.None, 99, "Make sure setting ItemSource to null doesn't blow up",
-		PlatformAffected.UWP)]
-	public class SetListViewItemSourceToNull : TestContentPage
-	{
-		const string Success = "Success";
-		const string Go = "Go";
-
-		protected override void Init()
-		{
-			var lv = new ListView();
-			var itemSource = new List<string>
-			{
-				"One",
-				"Two",
-				"Three"
-			};
-			lv.ItemsSource = itemSource;
-
-			var result = new Label();
-
-			var button = new Button { AutomationId = Go, Text = Go };
-
-			button.Clicked += (sender, args) =>
-			{
-				lv.ItemsSource = null;
-				result.Text = Success;
-			};
-
-			var instructions = new Label
-			{
-				Text = $"Tap the '{Go}' button. If the '{Success}' label is visible, this test has passed."
-			};
-
-			Content = new StackLayout
-			{
-				Children =
-				{
-					instructions,
-					button,
-					result,
-					lv
-				}
-			};
-		}
-	}
 }

src/Controls/tests/TestCases.HostApp/Issues/SetListViewItemSourceToNull.cs

@@ -0,0 +1,48 @@
+namespace Maui.Controls.Sample.Issues
+{
+[Issue(IssueTracker.None, 99, "Make sure setting ItemSource to null doesn't blow up",
+		PlatformAffected.UWP)]
+	public class SetListViewItemSourceToNull : TestContentPage
+	{
+		const string Success = "Success";
+		const string Go = "Go";
+
+		protected override void Init()
+		{
+			var lv = new ListView();
+			var itemSource = new List<string>
+			{
+				"One",
+				"Two",
+				"Three"
+			};
+			lv.ItemsSource = itemSource;
+
+			var result = new Label();
+
+			var button = new Button { AutomationId = Go, Text = Go };
+
+			button.Clicked += (sender, args) =>
+			{
+				lv.ItemsSource = null;
+				result.Text = Success;
+			};
+
+			var instructions = new Label
+			{
+				Text = $"Tap the '{Go}' button. If the '{Success}' label is visible, this test has passed."
+			};
+
+			Content = new StackLayout
+			{
+				Children =
+				{
+					instructions,
+					button,
+					result,
+					lv
+				}
+			};
+		}
+	}
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2929.cs

@@ -7,8 +7,6 @@ namespace Microsoft.Maui.TestCases.Tests.Issues
 	public class Issue2929 : _IssuesUITest
 	{
 		const string Success = "Success";
-		const string Go = "Go";
-
 		public Issue2929(TestDevice testDevice) : base(testDevice)
 		{
 		}
@@ -17,27 +15,10 @@ public Issue2929(TestDevice testDevice) : base(testDevice)
 
 		[Test]
 		[Category(UITestCategories.ListView)]
-		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void NullItemSourceDoesNotCrash()
 		{
 			// If we can see the Success label, it means we didn't crash. 
 			App.WaitForElement(Success);
 		}
-
-		[Test]
-		[Category(UITestCategories.ListView)]
-		[Category(UITestCategories.Compatibility)]
-		[FailsOnAllPlatformsWhenRunningOnXamarinUITest]
-		public void SettingItemsSourceToNullDoesNotCrash()
-		{
-			App.WaitForElement(Go);
-			App.Tap(Go);
-
-			// If we can see the Success label, it means we didn't crash. 
-			App.WaitForElement(Success);
-		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2963.cs

@@ -18,15 +18,11 @@ public Issue2963(TestDevice testDevice) : base(testDevice)
 
 		[Test]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void Issue2963Test()
 		{
-			App.Screenshot("I am at Issue 2963");
+			App.WaitForElement(EditorId);
 			App.Tap(EditorId);
-			ClassicAssert.AreEqual("False", App.FindElement(FocusedLabelId).GetText());
-			App.Screenshot("Label should still be false");
+			Assert.That(App.FindElement(FocusedLabelId).GetText(), Is.EqualTo("False"));
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3273.cs

@@ -14,15 +14,11 @@ public Issue3273(TestDevice testDevice) : base(testDevice)
 
 		[Test]
 		[Category(UITestCategories.Gestures)]
-		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		public void Issue3273Test()
 		{
 			App.WaitForElement("Move items");
 			App.Tap("Move items");
-			App.WaitForNoElement("Success");
+			App.WaitForElement("Success");
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue465.cs

@@ -14,16 +14,12 @@ public Issue465(TestDevice testDevice) : base(testDevice)
 
 		[Test]
 		[Category(UITestCategories.Navigation)]
-		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
 		public void Issue465TestsPushPopModal()
 		{
 			App.WaitForElement("PopPage");
-			App.Screenshot("All elements exist");
 
 			App.Tap("PopPage");
 			App.WaitForElement("Popppppped");
-			App.Screenshot("Popped modal successful");
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue6260.cs

@@ -17,10 +17,6 @@ public Issue6260(TestDevice testDevice) : base(testDevice)
 
 		[Test]
 		[Category(UITestCategories.Layout)]
-		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
-		[FailsOnWindowsWhenRunningOnXamarinUITest]
 		public void NonAppCompatBasicSwitchTest()
 		{
 			App.WaitForElement(success);

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7338.cs

@@ -16,11 +16,7 @@ public Issue7338(TestDevice testDevice) : base(testDevice)
 
 		[Test]
 		[Category(UITestCategories.CollectionView)]
-		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
-		[FailsOnWindowsWhenRunningOnXamarinUITest]
-		public void Issue3273Test()
+		public void Issue7338Test()
 		{
 			// If the instructions are visible at all, then this has succeeded
 			App.WaitForElement(Success);

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7371.cs

@@ -14,10 +14,6 @@ public Issue7371(TestDevice testDevice) : base(testDevice)
 
 		[Test]
 		[Category(UITestCategories.RefreshView)]
-		[Category(UITestCategories.Compatibility)]
-		[FailsOnAndroidWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
-		[FailsOnWindowsWhenRunningOnXamarinUITest]
 		public async Task RefreshingListViewCrashesWhenDisposedTest()
 		{
 			await Task.Delay(500);

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/SetListViewItemSourceToNull.cs

@@ -0,0 +1,29 @@
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues
+{
+	public class SetListViewItemSourceToNull : _IssuesUITest
+	{
+		const string Success = "Success";
+		const string Go = "Go";
+
+		public SetListViewItemSourceToNull(TestDevice testDevice) : base(testDevice)
+		{
+		}
+
+		public override string Issue => "Make sure setting ItemSource to null doesn't blow up";
+
+		[Test]
+		[Category(UITestCategories.ListView)]
+		public void SettingItemsSourceToNullDoesNotCrash()
+		{
+			App.WaitForElement(Go);
+			App.Tap(Go);
+
+			// If we can see the Success label, it means we didn't crash. 
+			App.WaitForElement(Success);
+		}
+	}
+}