Skip to content

Commit ba0be32

Browse files
github-actions[bot]HarishKumarSF4517rmarinho
authored
[inflight/current] [Testing] Fix for flaky UITests Issue18896 and disable Issue14471 test which fails in CI randomly (#28540)
* Improve stability for flaky test * Update Issue14471.cs * Don t allow pre release --------- Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com> Co-authored-by: Rui Marinho <me@ruimarinho.net>
1 parent 320b488 commit ba0be32

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
"Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.25161.4"
99
},
1010
"sdk": {
11-
"allowPrerelease": true
11+
"allowPrerelease": false
1212
}
1313
}

src/Controls/tests/TestCases.HostApp/Issues/Issue18896.xaml.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace Maui.Controls.Sample.Issues
22
{
3-
[Issue(IssueTracker.ManualTest, "C3", "Can scroll ListView inside RefreshView", PlatformAffected.All)]
3+
[Issue(IssueTracker.ManualTest, "C3", "Can scroll ListView inside RefreshView", PlatformAffected.All, isInternetRequired: true)]
44
public partial class Issue18896 : ContentPage
55
{
66
public Issue18896()

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue14471.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
using NUnit.Framework;
1+
#if TEST_FAILS_ON_ANDROID // This test fails randomly, likely because the image source has disappeared sometimes in CI, not able to reproduce locally. For now, we have ignored the test for Android. Issue for re-enabling: https://github.com/dotnet/maui/issues/24243
2+
using NUnit.Framework;
23
using UITest.Appium;
34
using UITest.Core;
45

@@ -23,4 +24,5 @@ public void ImageDoesntDisappearWhenNavigatingBack()
2324
// The test passes if image is loaded
2425
VerifyScreenshot();
2526
}
26-
}
27+
}
28+
#endif

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18896.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ public Issue18896(TestDevice device) : base(device)
2222
[FailsOnWindowsWhenRunningOnXamarinUITest("Currently fails on Windows; see https://github.com/dotnet/maui/issues/15994")]
2323
public void Issue18896Test()
2424
{
25+
VerifyInternetConnectivity();
2526
App.WaitForElement("WaitForStubControl");
2627

2728
App.ScrollDown(ListView);

0 commit comments

Comments
 (0)