Removed vestigial UpdateContentLayout() method left over from Forms

The Forms version of ItemContentView called the UpdateContentLayout method
when laying out each RecyclerView item to ensure that all cross-platform
layout updates were applied. When the CollectionView was ported to MAUI,
that method didn't appropriately handle the changes to margins in the layout,
so a call to LayoutVirtualView was added to deal with that. Both methods
effectively do the same job, so UpdateContentLayout is now redundant.

This change removes UpdateContentLayout so we don't lay out (and in some cases
re-measure) the content unnecessarily.

Author: hartez

src/Controls/src/Core/Handlers/Items/Android/ItemContentView.cs

@@ -2,8 +2,6 @@
 using System;
 using Android.Content;
 using Android.Views;
-using AndroidX.CoordinatorLayout.Widget;
-using AndroidX.Fragment.App;
 using Microsoft.Maui.Graphics;
 using AView = Android.Views.View;
 
@@ -23,26 +21,31 @@ public ItemContentView(Context context) : base(context)
 
 		internal void ClickOn() => CallOnClick();
 
+		AView PlatformView => Content?.ContainerView ?? Content?.PlatformView;
+
 		internal void RealizeContent(View view, ItemsView itemsView)
 		{
 			Content = CreateHandler(view, itemsView);
-			var platformView = Content.ContainerView ?? Content.PlatformView;
+			var platformView = PlatformView;
+
 			//make sure we don't belong to a previous Holder
 			platformView.RemoveFromParent();
 			AddView(platformView);
 
-			//TODO: RUI IS THIS THE BEST WAY TO CAST? 
-			(View as VisualElement).MeasureInvalidated += ElementMeasureInvalidated;
+			if (View is VisualElement visualElement)
+			{
+				visualElement.MeasureInvalidated += ElementMeasureInvalidated;
+			}
 		}
 
 		internal void Recycle()
 		{
-			if (View != null)
+			if (View is VisualElement visualElement)
 			{
-				(View as VisualElement).MeasureInvalidated -= ElementMeasureInvalidated;
+				visualElement.MeasureInvalidated -= ElementMeasureInvalidated;
 			}
 
-			var platformView = Content?.ContainerView ?? Content?.PlatformView;
+			var platformView = PlatformView;
 
 			if (platformView != null)
 			{
@@ -66,18 +69,10 @@ protected override void OnLayout(bool changed, int l, int t, int r, int b)
 				return;
 			}
 
-			var size = this.FromPixels(r - l, b - t);
-
-			//TODO: RUI Is this the best way?
-			//View.Arrange(new Rectangle(Point.Zero, size));
-			//Arrange doesn't seem to work as expected
-
-			if (View?.Handler is not IPlatformViewHandler handler)
-				return;
-
-			handler.LayoutVirtualView(l, t, r, b);
-
-			UpdateContentLayout();
+			if (View?.Handler is IPlatformViewHandler handler)
+			{
+				handler.LayoutVirtualView(l, t, r, b);
+			}
 		}
 
 		protected override void OnMeasure(int widthMeasureSpec, int heightMeasureSpec)
@@ -125,7 +120,7 @@ protected override void OnMeasure(int widthMeasureSpec, int heightMeasureSpec)
 			SetMeasuredDimension(pixelWidth, pixelHeight);
 		}
 
-		void ElementMeasureInvalidated(object sender, System.EventArgs e)
+		void ElementMeasureInvalidated(object sender, EventArgs e)
 		{
 			if (this.IsAlive())
 			{
@@ -137,32 +132,6 @@ void ElementMeasureInvalidated(object sender, System.EventArgs e)
 			}
 		}
 
-		void UpdateContentLayout()
-		{
-			VisualElement mauiControlsView = View as VisualElement;
-			AView aview = Content.ToPlatform();
-
-			if (mauiControlsView == null || aview == null)
-				return;
-
-			var x = (int)this.ToPixels(mauiControlsView.X);
-			var y = (int)this.ToPixels(mauiControlsView.Y);
-			var width = Math.Max(0, (int)this.ToPixels(mauiControlsView.Width));
-			var height = Math.Max(0, (int)this.ToPixels(mauiControlsView.Height));
-
-			aview.Layout(x, y, width, height);
-
-			if ((aview is LayoutViewGroup || aview is ContentViewGroup || aview is CoordinatorLayout || aview is FragmentContainerView) && width == 0 && height == 0)
-			{
-				// Nothing to do here; just chill.
-			}
-			else
-			{
-				aview.Measure(MeasureSpecMode.Exactly.MakeMeasureSpec(width), MeasureSpecMode.Exactly.MakeMeasureSpec(height));
-				aview.Layout(x, y, x + width, y + height);
-			}
-		}
-
 		static IPlatformViewHandler CreateHandler(View view, ItemsView itemsView) =>
 			TemplateHelpers.GetHandler(view, itemsView.FindMauiContext());
 	}