Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label TextType="Html" Crash in Windows if html is "Broken" #11311

Closed
lucianparvu opened this issue Nov 12, 2022 · 5 comments · Fixed by #11409
Closed

Label TextType="Html" Crash in Windows if html is "Broken" #11311

lucianparvu opened this issue Nov 12, 2022 · 5 comments · Fixed by #11409
Assignees
Labels
area-controls-label Label, Span fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/windows 🪟 t/bug Something isn't working
Milestone

Comments

@lucianparvu
Copy link

Description

Label TextType="Html" Crash in Windows if html "Is Broken" .

Same Html works in IOS and Android

How to check the Broken Html Before ?

<Label TextType="Html" Text="{Binding Item.Description}" VerticalOptions="Center" HorizontalOptions="Center" />

Steps to Reproduce

Link to public reproduction project repository

dont have

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

Windows

Did you find any workaround?

No response

Relevant log output

-
@lucianparvu lucianparvu added the t/bug Something isn't working label Nov 12, 2022
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Nov 14, 2022
@jsuarezruiz jsuarezruiz added the s/needs-repro Attach a solution or code which reproduces the issue label Nov 14, 2022
@ghost
Copy link

ghost commented Nov 14, 2022

Hi @lucianparvu. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@jsuarezruiz
Copy link
Contributor

Could you share the broken html used?

@lucianparvu
Copy link
Author

I tried to display description of an product inserted in DB by a web app using some html editor .

Link : https://github.com/lucianparvu/Files/blob/67ab161399e8333f67f4c9ad7bce86def02da8b7/BrokenHtml

@ghost ghost added s/needs-attention Issue has more information and needs another look and removed s/needs-repro Attach a solution or code which reproduces the issue labels Nov 14, 2022
@jsuarezruiz jsuarezruiz removed the s/needs-attention Issue has more information and needs another look label Nov 15, 2022
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Nov 15, 2022
@ghost
Copy link

ghost commented Nov 15, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@ne0rrmatrix
Copy link

This fix works for html strings that have https with a ? mark in them. It simply removes everything after ? mark so it can render. This fixes a small issue for me that allows the page to render by ignoring invalid data in links.

public static string RemoveBADHtmlTags(string HTMLCode)
    {
        HTMLCode = Regex.Replace(HTMLCode, "/\\?.*?.\"", "\"", RegexOptions.IgnoreCase | RegexOptions.Singleline);
        return HTMLCode;
    }

@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Feb 22, 2023
@samhouts samhouts modified the milestones: Backlog, 8.0-preview1 Feb 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-label Label, Span fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants