Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Shell tab icon change using Trigger cause rearrangement issue in Android , Works in IOS. #11520

Open
ganeshachary opened this issue Nov 21, 2022 · 7 comments
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@ganeshachary
Copy link

ganeshachary commented Nov 21, 2022

Description

Changing the App Shell tab icon using style triggers causes the tab bar icon to shift and rearrange on icon change.
Works fine in IOS.

Steps to Reproduce

  1. In App shell XAML add the style
 <Shell.Resources>
        <Style TargetType="ShellContent" x:Key="NotificationStyle">
            <Style.Triggers>
                <Trigger TargetType="ShellContent" Property="IsChecked" Value="True">
                    <Setter Property="Icon" Value="message_read"/>                  
                </Trigger>
                   <Trigger TargetType="ShellContent" Property="IsChecked" Value="False">
                    <Setter Property="Icon" Value="message_unread"/>                  
                </Trigger>
            </Style.Triggers>
        </Style>
    </Shell.Resources>
  1. Apply to the tab
    <ShellContent Title="Notifications" Style="{StaticResource NotificationStyle}" ContentTemplate="{DataTemplate local:NotificationsPage}" Route="NotificationsPage"/>

Link to public reproduction project repository

https://github.com/ganeshachary/mauibugTabiconChange

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

eg Android 23 to 33

Did you find any workaround?

Not able to find any workaround

Relevant log output

NA
@ganeshachary ganeshachary added the t/bug Something isn't working label Nov 21, 2022
@jsuarezruiz jsuarezruiz added platform/android 🤖 area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Nov 21, 2022
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Nov 21, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@jinxinjuan jinxinjuan added s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage labels Jun 28, 2023
@jinxinjuan
Copy link

Verified this issue with Visual Studio Enterprise 17.7.0 Preview 2.0. Can repro on android platform with sample cade. mauibugTabiconChange

@AdamDiament
Copy link

AdamDiament commented Jul 3, 2023

I am having the same issue, the menu icon jumps into existence on every page load when setting the icon using code behind, and looks janky

@agerman77
Copy link

Same issue here. Strange shuffling happens when changing icons from codebehind / viewModel.

@FelixCEriksson
Copy link

I have the same issue. It only happens on android. I hope this gets fixed

@SliemBeji-FBC
Copy link

Same Issue here

@dantelegacyheating
Copy link

This also occurs if you change the IsVisible property of a tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants