Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IImage.AsBytes() takes float quality 0..1 but complains about quality not being 0..100 when 50 is entered #12158

Closed
janseris opened this issue May 6, 2022 · 6 comments · Fixed by #13208
Labels
fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/android 🤖 s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working
Milestone

Comments

@janseris
Copy link

janseris commented May 6, 2022

Description

Probably just the exception message is wrong.

When calling image.AsBytes for a jpg image with quality 50, the following code is executed:

image

but it outputs:

**Java.Lang.IllegalArgumentException:** 'quality must be 0..100'

I don't know if Windows is affected because Windows cannot load IImage at all currently.

Steps to Reproduce

export IImage on Android

Version with bug

Release Candidate 2 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android, I was not able test on other platforms

Affected platform versions

Android 11 (API 30)

Did you find any workaround?

use quality / 100f -> 0..1

Relevant log output

No response

@janseris janseris added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels May 6, 2022
@janseris janseris changed the title IImage.AsBytes() takes float quality but complains about quality not being between 0 and 100 IImage.AsBytes() takes float quality 0..1 but complains about quality not being 0..100 May 7, 2022
@janseris janseris changed the title IImage.AsBytes() takes float quality 0..1 but complains about quality not being 0..100 IImage.AsBytes() takes float quality 0..1 but complains about quality not being 0..100 when 50 is entered May 7, 2022
@drasticactions drasticactions transferred this issue from dotnet/maui May 7, 2022
@janseris
Copy link
Author

janseris commented Dec 15, 2022

@drasticactions @mattleibow @Redth
Hi is anyone from MAUI reading issues in this repository? What should I do when I have bugs for Maui.Graphics repository? I have opened multiple issues with image processing more 7 months ago and none of them received a response or a fix.
Thank you

@drasticactions drasticactions transferred this issue from dotnet/Microsoft.Maui.Graphics Dec 16, 2022
@drasticactions
Copy link
Contributor

@janseris The code has since moved into the MAUI repo, so none of those issues are probably being triaged. I moved it for you.

@drasticactions
Copy link
Contributor

@mattleibow @Redth We might want to put a note or something on the Maui.Graphics repo to let people know of this change.

@janseris
Copy link
Author

janseris commented Dec 16, 2022

@drasticactions Thank you. Could you please also move my 2 other issues from the Maui.Graphics repo to MAUI?
It's these two:
#13902
dotnet/Microsoft.Maui.Graphics#422
And also this issue which is very much related to my issue 423:
dotnet/Microsoft.Maui.Graphics#450

@mattleibow mattleibow added this to the Backlog milestone Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@mattleibow mattleibow moved this from Todo to In Progress in MAUI SDK Ongoing Feb 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Feb 9, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Feb 23, 2023
@Christerad
Copy link

@drasticactions Thank you. Could you please also move my 2 other issues from the Maui.Graphics repo to MAUI? It's these two: dotnet/maui#13902 dotnet/Microsoft.Maui.Graphics#422 And also this issue which is very much related to my issue 423: dotnet/Microsoft.Maui.Graphics#450

#13902
dotnet/Microsoft.Maui.Graphics#422
These problem isnt being solved ? any updates ?

@samhouts samhouts modified the milestones: Backlog, 8.0-preview1 Apr 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/android 🤖 s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants