Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CornerRadius on Border in .net 7 #13699

Closed
tjbarrott opened this issue Mar 4, 2023 · 2 comments · Fixed by #13793
Closed

CornerRadius on Border in .net 7 #13699

tjbarrott opened this issue Mar 4, 2023 · 2 comments · Fixed by #13793
Assignees
Labels
area-controls-border Border area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! platform/android 🤖 platform/windows 🪟 t/bug Something isn't working

Comments

@tjbarrott
Copy link

Description

CornerRadius is not binding to Self for Border control.
This works on .net 6, and it use to work on .net 7 with Visual Studio 2022 17.3. I noticed the change in Visual Studio 2022 17.4.5

Steps to Reproduce

Put in a border with this as the style:

                <Style x:Key="BorderStyle" TargetType="Border">
			<Setter Property="StrokeThickness" Value="5"/> 
			<Setter Property="StrokeShape">
				<RoundRectangle>
					<RoundRectangle.CornerRadius>
						<Binding Path="Height" Source="{RelativeSource Self}"/>
					</RoundRectangle.CornerRadius>
				</RoundRectangle>
			</Setter>
		</Style>

Link to public reproduction project repository

none yet

Version with bug

7.0 (current)

Last version that worked well

6.0.312

Affected platforms

Android, Windows, I was not able test on other platforms

Affected platform versions

Android 13

Did you find any workaround?

no

Relevant log output

No response

@tjbarrott tjbarrott added the t/bug Something isn't working label Mar 4, 2023
@tjbarrott
Copy link
Author

<ContentPage.Resources>
    <Style x:Key="BorderStyle" TargetType="Border">
	<Setter Property="StrokeThickness" Value="5"/> 
	<Setter Property="StrokeShape">
		<RoundRectangle>
			<RoundRectangle.CornerRadius>
				<Binding Path="Height" Source="{RelativeSource Self}"/>
			</RoundRectangle.CornerRadius>
		</RoundRectangle>
	</Setter>
    </Style>
</ContentPage.Resources>

<Border Style="{DynamicResource BorderStyle}">
	<Grid ColumnDefinitions="Auto,*">
		<ImageButton
			Grid.Column="0"
			Source="dotnet_bot.png"
			HeightRequest="50"
			WidthRequest="50" />

		<Label
			Grid.Column="1"
                        Text="Hello, World!"
                        SemanticProperties.HeadingLevel="Level1"
                        FontSize="32"
                        HorizontalOptions="Center" />
	</Grid>
</Border>

@jsuarezruiz jsuarezruiz added area-xaml XAML, CSS, Triggers, Behaviors area-controls-border Border labels Mar 6, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 6, 2023
@rachelkang rachelkang added this to the Backlog milestone Mar 6, 2023
@ghost
Copy link

ghost commented Mar 6, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@jsuarezruiz jsuarezruiz self-assigned this Mar 6, 2023
@jsuarezruiz jsuarezruiz moved this from Todo to In Progress in MAUI SDK Ongoing Mar 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Mar 22, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Apr 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
@samhouts samhouts modified the milestones: Backlog, .NET 8 May 24, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-border Border area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! platform/android 🤖 platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants