[Android] NullReferenceException in ShellFlyoutTemplatedContentRenderer.HeaderContainer.UpdateMinimumHeight

[BioTurboNick]

Description

Report in AppCenter of a NullReferenceException in ShellFlyoutTemplatedContentRenderer.HeaderContainer.UpdateMinimumHeight

I haven't seen this crash before 7.0.59, but I can't say it isn't just something rare I haven't yet seen.

Opportunities for nulls are:

• Context on line 772, 776
• PlatformView on line 792

Assuming the isolated error can be addressed, perhaps line 792 should at a minimum change to PlatformView?.MinimumHeight != minHeight) ?

maui/src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellFlyoutTemplatedContentRenderer.cs

Lines 766 to 796 in ae20455

	void UpdateMinimumHeight()
	{
	var minHeight = 0;
	if (View?.MinimumHeightRequest > 0)
	{
	minHeight = (int)Context.ToPixels(View.MinimumHeightRequest);
	}
	else if (_flyoutHeaderBehavior == FlyoutHeaderBehavior.CollapseOnScroll)
	{
	minHeight = Context.GetActionBarHeight();
	}
	else
	{
	minHeight = 0;
	}
	if (MinimumHeight != minHeight)
	this.SetMinimumHeight(minHeight);
	if (Parent is AView frameLayoutView &&
	minHeight > frameLayoutView.MinimumHeight)
	{
	frameLayoutView.SetMinimumHeight(minHeight);
	}
	if (PlatformView.MinimumHeight != minHeight)
	{
	PlatformView.SetMinimumHeight(minHeight);
	}
	}

Steps to Reproduce

Unknown

Link to public reproduction project repository

not yet

Version with bug

7.0 (current)

Last version that worked well

7.0 (current)

Affected platforms

Android

Affected platform versions

Android 10

Did you find any workaround?

No response

Relevant log output

Microsoft.Maui.Controls.Platform.Compatibility.ShellFlyoutTemplatedContentRenderer.HeaderContainer.UpdateMinimumHeight()
Microsoft.Maui.Controls.Platform.Compatibility.ShellFlyoutTemplatedContentRenderer.HeaderContainer.OnMeasure(Int32 widthMeasureSpec, Int32 heightMeasureSpec)
Android.Views.View.n_OnMeasure_II(IntPtr , IntPtr , Int32 , Int32 )
Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPII_V(_JniMarshal_PPII_V , IntPtr , IntPtr , Int32 , Int32 )

[BioTurboNick]

bump - if someone could just tell me if the simple null-guarding change is fine, I'll make the PR for it.

[fekberg]

I'm getting this on Pixel 7 and One Plus 8 Pro, but not on any Samsung phones.