Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAML Hot Reload is broken within Shell.TitleView #13992

Closed
Tracked by #14032
spadapet opened this issue Mar 16, 2023 · 3 comments · Fixed by #14006
Closed
Tracked by #14032

XAML Hot Reload is broken within Shell.TitleView #13992

spadapet opened this issue Mar 16, 2023 · 3 comments · Fixed by #14006
Assignees
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-controls-titleview TitleView fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences platform/windows 🪟 t/bug Something isn't working

Comments

@spadapet
Copy link
Contributor

Description

XAML hot reload just doesn't work within Shell.TitleView.

Steps to Reproduce

REPRO:

  1. In VS, create new blank MAUI app
    image
  2. Open AppShell.xaml and set the TitleView property with something:
    <Shell.TitleView>
        <Label Text="Hello Title!" />
    </Shell.TitleView>
    
  3. F5 to build and debug your app. notice the new title:
    image
  4. Change anything in the TitleView, like the Label's text:
    <Shell.TitleView>
        <Label Text="Hot Reload Title!" />
    </Shell.TitleView>
    

RESULT:
XAML changes are not hot reloaded into the running app (of course make sure XAML hot reload is enabled)

EXPECT:
XAML changes in Shell.TitleView should be hot reloaded and affect the running app

Link to public reproduction project repository

N/A use blank template

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android, Windows, I was not able test on other platforms

Affected platform versions

net7.0-windows10.0.19041.0, net7.0-android21.0

Did you find any workaround?

No, have to restart the app :(

Relevant log output

No response

@spadapet spadapet added the t/bug Something isn't working label Mar 16, 2023
@PureWeen PureWeen added platform/windows 🪟 area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Mar 16, 2023
@PureWeen PureWeen added this to the Backlog milestone Mar 16, 2023
@ghost
Copy link

ghost commented Mar 16, 2023

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@drasticactions
Copy link
Contributor

drasticactions commented Mar 17, 2023

Notes: If you remove and reapply the TitleView element whole, it will update.

This also isn't specific to Shell, it happens on NavigationView.TitleView as well. Maybe the nested-ness of how it's laid out causes XAML Actions not to be generated?

It's also not specific to Windows, it should be happening on all platforms.

@drasticactions drasticactions added the partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences label Mar 17, 2023
@drasticactions
Copy link
Contributor

Ahhh, I think I know why:

image

TitleView is not represented in as part of the child of the page. We're therefore not able to track it in LVT, so we can't generate actions for it. We'll need to get that represented in MAUI for those changes to be seen.

@drasticactions drasticactions self-assigned this Mar 17, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Apr 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
@samhouts samhouts modified the milestones: Backlog, .NET 8 May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-controls-titleview TitleView fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants