Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnSpacing docs incorrect #15115

Closed
RobWos opened this issue May 16, 2023 · 0 comments · Fixed by #15425
Closed

ColumnSpacing docs incorrect #15115

RobWos opened this issue May 16, 2023 · 0 comments · Fixed by #15425
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-8.0.0-preview.6.8686 Look for this fix in 8.0.0-preview.6.8686! t/bug Something isn't working t/docs 📝

Comments

@RobWos
Copy link

RobWos commented May 16, 2023

Description

The docs mention that the default columnspacing of a grid is 6.

<value>The space between columns in this <see cref="T:Microsoft.Maui.Controls.Grid" /> layout. The default is 6.</value>

Meanwhile the actual default is 0, it had a default of 6 in Xamarin.

Default 0 in MAUI, the second value here is the default of the bindable property.

typeof(Grid), 0d, propertyChanged: Invalidate);

Default of 6 in Xamarin
https://github.com/xamarin/Xamarin.Forms/blob/d68e84f6ea4d1c97b63aeaa9d2780c3bee3a4f59/Xamarin.Forms.Core/Grid.cs#L23

When updating the docs maybe also update the summary as currently it differs from the RowSpacing

ColumnSpacing:

<summary>Provides the interface for the bound property that gets or sets the distance between columns in the Grid.</summary>

RowSpacing:

<summary>Gets or sets the amount of space left between rows in the Grid. This is a bindable property.</summary>

@RobWos RobWos added the t/bug Something isn't working label May 16, 2023
@Eilon Eilon added area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter t/docs 📝 labels May 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 5, 2023
@samhouts samhouts modified the milestones: .NET 8 Planning, .NET 8 Jul 10, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.6.8686 Look for this fix in 8.0.0-preview.6.8686! label Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-8.0.0-preview.6.8686 Look for this fix in 8.0.0-preview.6.8686! t/bug Something isn't working t/docs 📝
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants