Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression/8.0.0-preview.1.7762] [WinUI] CollectionView runtime binding errors when loading the ItemSource asynchronously #16787

Closed
nicop85 opened this issue Aug 16, 2023 · 7 comments · Fixed by #17348
Assignees
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! i/regression This issue described a confirmed regression on a currently supported version partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@nicop85
Copy link

nicop85 commented Aug 16, 2023

Description

I was testing the last updates available for the Net 8 preview 6 (using Visual Studio 17.7), to see if everything continues to works as expected.

What I have found is that if you have a CollectionView that uses data binding inside it's DataTemplate, WinUI will report some binding problems if you load the ItemSource asynchronously like when you go to some API to get the data and then fill the ItemSource list with that data.

If you load the ItemsSource without waiting for an asynchronous response, everything work as expected.

App after showing the list:
image

Binding errors:
image

Steps to Reproduce

  1. Download the project linked below
  2. Run it targeting Windows

Link to public reproduction project repository

https://github.com/nicop85/CollectionViewBindingProblems.git

Version with bug

8.0.0-preview.1.7762

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

7.0.92

Affected platforms

Windows

Affected platform versions

Windows 10.0.17763.0

Did you find any workaround?

No

Relevant log output

No response

@nicop85 nicop85 added the t/bug Something isn't working label Aug 16, 2023
@Eilon Eilon added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Aug 16, 2023
@samhouts samhouts changed the title [WinUI / 8.0.0-preview.6] CollectionView runtime binding errors when loading the ItemSource asynchronously [regression/8.0.0-preview.6] [WinUI] CollectionView runtime binding errors when loading the ItemSource asynchronously Aug 16, 2023
@samhouts samhouts added the i/regression This issue described a confirmed regression on a currently supported version label Aug 16, 2023
@samhouts samhouts added this to the .NET 8 GA milestone Aug 16, 2023
@mattleibow mattleibow added area-xaml XAML, CSS, Triggers, Behaviors area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging and removed platform/windows 🪟 i/regression This issue described a confirmed regression on a currently supported version labels Aug 16, 2023
@mattleibow
Copy link
Member

@StephaneDelcroix thoughts?

@samhouts
Copy link
Member

samhouts commented Aug 16, 2023

Could be the same as #11956 or #8433 or #13754 or #15579

@samhouts samhouts changed the title [regression/8.0.0-preview.6] [WinUI] CollectionView runtime binding errors when loading the ItemSource asynchronously [WinUI] CollectionView runtime binding errors when loading the ItemSource asynchronously Aug 16, 2023
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Aug 24, 2023
@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.8.0 Preview 1.0. Repro on Windows 11 .NET 8 with below Project:
CollectionViewBindingProblems.zip

image

@samhouts samhouts added the potential-regression This issue described a possible regression on a currently supported version., verification pending label Sep 5, 2023
@TiberiusDRAIG
Copy link

Just adding my name to this as it completely blocks our upgrade to .NET 8 - we are effectively stuck on our landing page because none of the controls generated by CollectionView have any context, ergo are completely non-functional. This basically blocks any real testing of .NET 8 since we cannot progress past this point without rewriting code.

This is a major issue for us with the timescales involved - the more time we lose to things like this, the less time we have to properly test our end-of-year release.

@samhouts
Copy link
Member

samhouts commented Sep 12, 2023

Confirmed that this regressed between 7.0.92...8.0.0-preview.1.7762. Still reproducible on nightly. Some of the errors seem inconsequential and the binding is resolved, while other bindings appear to not work at all.

#10999 seems sus.

@jeremy-visionaid
Copy link
Contributor

@samhouts Good catch, thanks! I can at least confirm that reverting #10999 resolves #17192

@samhouts samhouts added i/regression This issue described a confirmed regression on a currently supported version and removed potential-regression This issue described a possible regression on a currently supported version., verification pending labels Sep 12, 2023
@samhouts samhouts changed the title [WinUI] CollectionView runtime binding errors when loading the ItemSource asynchronously [regression/8.0.0-preview.1.7762] [WinUI] CollectionView runtime binding errors when loading the ItemSource asynchronously Sep 12, 2023
@jeremy-visionaid
Copy link
Contributor

I hope we're going to see a pretty quick turn around on a new RC given how serious this one is - pretty much a blocker for using MAUI on Windows. At least I can continue with a local build, but I assume someone else might want to come up with a better fix than just reverting #10999? @espenrl @PureWeen @hartez

@PureWeen PureWeen self-assigned this Sep 13, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Sep 14, 2023
@mikeparker104 mikeparker104 added the partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with label Sep 18, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! i/regression This issue described a confirmed regression on a currently supported version partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants